Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 1240123003: Rename poorly named files. (Closed)

Created:
5 years, 5 months ago by iannucci
Modified:
5 years, 5 months ago
Reviewers:
dnj, Vadim Sh., estaab
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/infra/infra.git@fix_memlock
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : reparent --root #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-4 lines, -1887 lines) Patch
D go/src/infra/gae/libs/gae/memory/datastore_query.go View 1 chunk +0 lines, -594 lines 0 comments Download
A + go/src/infra/gae/libs/gae/memory/raw_datastore.go View 0 chunks +-1 lines, --1 lines 0 comments Download
A + go/src/infra/gae/libs/gae/memory/raw_datastore_data.go View 0 chunks +-1 lines, --1 lines 0 comments Download
A + go/src/infra/gae/libs/gae/memory/raw_datastore_query.go View 0 chunks +-1 lines, --1 lines 0 comments Download
A + go/src/infra/gae/libs/gae/memory/raw_datastore_test.go View 0 chunks +-1 lines, --1 lines 0 comments Download
D go/src/infra/gae/libs/gae/memory/raw_datstore.go View 1 chunk +0 lines, -184 lines 0 comments Download
D go/src/infra/gae/libs/gae/memory/raw_datstore_data.go View 1 chunk +0 lines, -516 lines 0 comments Download
D go/src/infra/gae/libs/gae/memory/raw_datstore_test.go View 1 chunk +0 lines, -597 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
iannucci
5 years, 5 months ago (2015-07-17 18:26:58 UTC) #1
dnj
lgtm
5 years, 5 months ago (2015-07-17 18:43:07 UTC) #2
commit-bot: I haz the power
This CL has an open dependency (Issue 1233413002 Patch 40001). Please resolve the dependency and ...
5 years, 5 months ago (2015-07-17 18:47:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1240123003/20001
5 years, 5 months ago (2015-07-17 18:49:38 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-17 18:53:11 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/infra/infra/+/fdc2fe5a97c1cfbd318b62e690941...

Powered by Google App Engine
This is Rietveld 408576698