Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: pkg/args/lib/args.dart

Issue 12401002: Make List.from and Iterable.toList default to not growable. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/args/lib/src/parser.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/args/lib/args.dart
diff --git a/pkg/args/lib/args.dart b/pkg/args/lib/args.dart
index 7760a99f53edff164670dba4b5b3ad96dd0d4511..6bdcb7e9805e1e54f32ac3fc2ae11d8c44e29e98 100644
--- a/pkg/args/lib/args.dart
+++ b/pkg/args/lib/args.dart
@@ -307,7 +307,7 @@ class ArgParser {
* flags and options defined by this parser, and returns the result.
*/
ArgResults parse(List<String> args) =>
- new Parser(null, this, args.toList(growable: true)).parse();
+ new Parser(null, this, args.toList()).parse();
/**
* Generates a string displaying usage information for the defined options.
@@ -397,6 +397,6 @@ class ArgResults {
}
/** Get the names of the options as a [Collection]. */
- Collection<String> get options => _options.keys.toList();
+ Collection<String> get options => _options.keys.toList(growable: false);
}
« no previous file with comments | « no previous file | pkg/args/lib/src/parser.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698