sdk/lib/web_sql/dart2js/web_sql_dart2js.dart - Issue 12401002: Make List.from and Iterable.toList default to not growable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/web_sql/dart2js/web_sql_dart2js.dart

Issue 12401002: Make List.from and Iterable.toList default to not growable. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/web_sql/dart2js/web_sql_dart2js.dart

diff --git a/sdk/lib/web_sql/dart2js/web_sql_dart2js.dart b/sdk/lib/web_sql/dart2js/web_sql_dart2js.dart

index dffe3ba2490dc5d469089105eeec69bb36fd46b9..7b68ee54818f84ee8d5e3baa99090156cf9845a5 100644

--- a/sdk/lib/web_sql/dart2js/web_sql_dart2js.dart

+++ b/sdk/lib/web_sql/dart2js/web_sql_dart2js.dart

@@ -287,7 +287,7 @@ class SqlResultSetRowList implements JavaScriptIndexingBehavior, List<Map> nativ

bool any(bool f(Map element)) => IterableMixinWorkaround.any(this, f);

- List<Map> toList({ bool growable: false }) =>

+ List<Map> toList({ bool growable: true }) =>

new List<Map>.from(this, growable: growable);

Set<Map> toSet() => new Set<Map>.from(this);

« no previous file with comments | « sdk/lib/svg/dartium/svg_dartium.dart ('k') | sdk/lib/web_sql/dartium/web_sql_dartium.dart » ('j') | no next file with comments »