Source/core/dom/Node.cpp - Issue 124003003: Add ascii() / latin1() / utf8() methods to AtomicString to avoid having to call string()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Node.cpp

Issue 124003003: Add ascii() / latin1() / utf8() methods to AtomicString to avoid having to call string() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/Node.cpp

diff --git a/Source/core/dom/Node.cpp b/Source/core/dom/Node.cpp

index 4b01f59b0e8be2fede36812d0af8b789691927ab..2ac631deb846408f0e14b6ce920241905e9b7356 100644

--- a/Source/core/dom/Node.cpp

+++ b/Source/core/dom/Node.cpp

@@ -1968,11 +1968,12 @@ void Node::showNodePathForThis() const

if (previous->nodeName() == node->nodeName())

++count;

if (hasIdAttr)

- fprintf(stderr, "[@id=\"%s\" and position()=%d]", idattr.string().utf8().data(), count);

+ fprintf(stderr, "[@id=\"%s\" and position()=%d]", idattr.utf8().data(), count);

else

fprintf(stderr, "[%d]", count);

- } else if (hasIdAttr)

- fprintf(stderr, "[@id=\"%s\"]", idattr.string().utf8().data());

+ } else if (hasIdAttr) {

+ fprintf(stderr, "[@id=\"%s\"]", idattr.utf8().data());

+ }

break;

}

case TEXT_NODE:

« no previous file with comments | « no previous file | Source/core/events/GenericEventQueue.cpp » ('j') | no next file with comments »