Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(884)

Side by Side Diff: Source/core/html/track/vtt/VTTCue.cpp

Issue 124003003: Add ascii() / latin1() / utf8() methods to AtomicString to avoid having to call string() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/html/MediaFragmentURIParser.cpp ('k') | Source/core/loader/ProgressTracker.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013, Opera Software ASA. All rights reserved. 2 * Copyright (c) 2013, Opera Software ASA. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 208 matching lines...) Expand 10 before | Expand all | Expand 10 after
219 } 219 }
220 220
221 VTTCue::~VTTCue() 221 VTTCue::~VTTCue()
222 { 222 {
223 displayTreeInternal()->remove(ASSERT_NO_EXCEPTION); 223 displayTreeInternal()->remove(ASSERT_NO_EXCEPTION);
224 } 224 }
225 225
226 #ifndef NDEBUG 226 #ifndef NDEBUG
227 String VTTCue::toString() const 227 String VTTCue::toString() const
228 { 228 {
229 return String::format("%p id=%s interval=%f-->%f cue=%s)", this, id().string ().utf8().data(), startTime(), endTime(), text().utf8().data()); 229 return String::format("%p id=%s interval=%f-->%f cue=%s)", this, id().utf8() .data(), startTime(), endTime(), text().utf8().data());
230 } 230 }
231 #endif 231 #endif
232 232
233 PassRefPtr<VTTCueBox> VTTCue::displayTreeInternal() 233 PassRefPtr<VTTCueBox> VTTCue::displayTreeInternal()
234 { 234 {
235 if (!m_displayTree) 235 if (!m_displayTree)
236 m_displayTree = VTTCueBox::create(document(), this); 236 m_displayTree = VTTCueBox::create(document(), this);
237 return m_displayTree; 237 return m_displayTree;
238 } 238 }
239 239
(...skipping 849 matching lines...) Expand 10 before | Expand all | Expand 10 after
1089 return m_cueBackgroundBox->executionContext(); 1089 return m_cueBackgroundBox->executionContext();
1090 } 1090 }
1091 1091
1092 Document& VTTCue::document() const 1092 Document& VTTCue::document() const
1093 { 1093 {
1094 ASSERT(m_cueBackgroundBox); 1094 ASSERT(m_cueBackgroundBox);
1095 return m_cueBackgroundBox->document(); 1095 return m_cueBackgroundBox->document();
1096 } 1096 }
1097 1097
1098 } // namespace WebCore 1098 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/html/MediaFragmentURIParser.cpp ('k') | Source/core/loader/ProgressTracker.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698