Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1481)

Unified Diff: mojo/services/network/url_loader_impl_apptest.cc

Issue 1239993004: Fix all failed and canceled URLRequestStatuses without errors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix more failures Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/network/url_loader_impl_apptest.cc
diff --git a/mojo/services/network/url_loader_impl_apptest.cc b/mojo/services/network/url_loader_impl_apptest.cc
index 872485e775f3889e7e26a71f8ce6471988be7593..bab615384704d0d3a500d724937f195964e58de4 100644
--- a/mojo/services/network/url_loader_impl_apptest.cc
+++ b/mojo/services/network/url_loader_impl_apptest.cc
@@ -11,8 +11,10 @@
#include "mojo/common/message_pump_mojo.h"
#include "mojo/services/network/network_context.h"
#include "mojo/services/network/url_loader_impl.h"
+#include "net/base/net_errors.h"
#include "net/url_request/url_request_job.h"
#include "net/url_request/url_request_job_factory_impl.h"
+#include "net/url_request/url_request_status.h"
#include "net/url_request/url_request_test_util.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/mojo/src/mojo/public/cpp/bindings/interface_request.h"
@@ -59,7 +61,8 @@ class TestURLRequestJob : public net::URLRequestJob {
void NotifyReadComplete(int bytes_read) {
if (bytes_read < 0) {
status_ = COMPLETED;
- NotifyDone(net::URLRequestStatus(net::URLRequestStatus::FAILED, 0));
+ NotifyDone(net::URLRequestStatus(
+ net::URLRequestStatus::FromError(net::ERR_FAILED)));
net::URLRequestJob::NotifyReadComplete(0);
} else if (bytes_read == 0) {
status_ = COMPLETED;
« no previous file with comments | « google_apis/gcm/engine/registration_request_unittest.cc ('k') | net/url_request/url_request_file_dir_job.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698