Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: google_apis/gcm/engine/registration_request_unittest.cc

Issue 1239993004: Fix all failed and canceled URLRequestStatuses without errors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix more failures Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: google_apis/gcm/engine/registration_request_unittest.cc
diff --git a/google_apis/gcm/engine/registration_request_unittest.cc b/google_apis/gcm/engine/registration_request_unittest.cc
index 437045894502c69b3401d289d76ceb9c5a1ce4c7..683e1d8ae4a2925093045f115bae638d0d902be4 100644
--- a/google_apis/gcm/engine/registration_request_unittest.cc
+++ b/google_apis/gcm/engine/registration_request_unittest.cc
@@ -13,6 +13,7 @@
#include "google_apis/gcm/engine/instance_id_get_token_request_handler.h"
#include "google_apis/gcm/monitoring/fake_gcm_stats_recorder.h"
#include "net/base/load_flags.h"
+#include "net/base/net_errors.h"
#include "net/url_request/url_request_status.h"
namespace gcm {
@@ -320,12 +321,11 @@ TEST_F(GCMRegistrationRequestTest, RequestNotSuccessful) {
CreateRequest("sender1,sender2");
request_->Start();
- net::URLRequestStatus request_status(net::URLRequestStatus::FAILED, 1);
SetResponse(net::HTTP_OK, "token=2501");
net::TestURLFetcher* fetcher = GetFetcher();
ASSERT_TRUE(fetcher);
- GetFetcher()->set_status(request_status);
+ GetFetcher()->set_status(net::URLRequestStatus::FromError(net::ERR_FAILED));
CompleteFetch();
« no previous file with comments | « google_apis/gaia/oauth2_mint_token_flow_unittest.cc ('k') | mojo/services/network/url_loader_impl_apptest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698