google_apis/gaia/gaia_auth_fetcher_unittest.cc - Issue 1239993004: Fix all failed and canceled URLRequestStatuses without errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: google_apis/gaia/gaia_auth_fetcher_unittest.cc

Issue 1239993004: Fix all failed and canceled URLRequestStatuses without errors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix more failures Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/speech/google_streaming_remote_engine_unittest.cc ('k') | google_apis/gaia/gaia_oauth_client_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: google_apis/gaia/gaia_auth_fetcher_unittest.cc

diff --git a/google_apis/gaia/gaia_auth_fetcher_unittest.cc b/google_apis/gaia/gaia_auth_fetcher_unittest.cc

index 28e5aff83c67ab77b85d6886165681c956b52c87..042decdd46a9dbf9e74f36263c462191f7dd0e1b 100644

--- a/google_apis/gaia/gaia_auth_fetcher_unittest.cc

+++ b/google_apis/gaia/gaia_auth_fetcher_unittest.cc

@@ -53,17 +53,16 @@ MockFetcher::MockFetcher(bool success,

net::URLFetcherDelegate* d)

: TestURLFetcher(0, url, d) {

set_url(url);

- net::URLRequestStatus::Status code;

+ net::Error error;

if (success) {

+ error = net::OK;

set_response_code(net::HTTP_OK);

- code = net::URLRequestStatus::SUCCESS;

} else {

- set_response_code(net::HTTP_FORBIDDEN);

- code = net::URLRequestStatus::FAILED;

+ error = net::ERR_FAILED;

}

- set_status(net::URLRequestStatus(code, 0));

+ set_status(net::URLRequestStatus::FromError(error));

SetResponseString(results);

}