content/browser/geolocation/network_location_provider_unittest.cc - Issue 1239993004: Fix all failed and canceled URLRequestStatuses without errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/geolocation/network_location_provider_unittest.cc

Issue 1239993004: Fix all failed and canceled URLRequestStatuses without errors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix more failures Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/proximity_auth/cryptauth/cryptauth_api_call_flow_unittest.cc ('k') | content/browser/speech/google_streaming_remote_engine_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/geolocation/network_location_provider_unittest.cc

diff --git a/content/browser/geolocation/network_location_provider_unittest.cc b/content/browser/geolocation/network_location_provider_unittest.cc

index 2e8bb4f3f7c5d8a1aaa09abdda673783f7a1f70a..f1171d2908fde5f4764932e24cb5d4e755c32fd6 100644

--- a/content/browser/geolocation/network_location_provider_unittest.cc

+++ b/content/browser/geolocation/network_location_provider_unittest.cc

@@ -14,6 +14,7 @@

#include "content/browser/geolocation/location_arbitrator_impl.h"

#include "content/browser/geolocation/network_location_provider.h"

#include "content/browser/geolocation/wifi_data_provider.h"

+#include "net/base/net_errors.h"

#include "net/url_request/test_url_fetcher_factory.h"

#include "net/url_request/url_request_status.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -437,7 +438,7 @@ TEST_F(GeolocationNetworkProviderTest, MultipleWifiScansComplete) {

// ...reply with a network error.

fetcher->set_url(test_server_url_);

- fetcher->set_status(net::URLRequestStatus(net::URLRequestStatus::FAILED, -1));

+ fetcher->set_status(net::URLRequestStatus::FromError(net::ERR_FAILED));

fetcher->set_response_code(200); // should be ignored

fetcher->SetResponseString(std::string());

fetcher->delegate()->OnURLFetchComplete(fetcher);