Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(969)

Unified Diff: components/domain_reliability/monitor_unittest.cc

Issue 1239993004: Fix all failed and canceled URLRequestStatuses without errors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix more failures Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/domain_reliability/monitor_unittest.cc
diff --git a/components/domain_reliability/monitor_unittest.cc b/components/domain_reliability/monitor_unittest.cc
index 9089287c2610edacd70f27b20a89c9bb365e8d46..ffa284982631979bab17e928db2522526d6d1351 100644
--- a/components/domain_reliability/monitor_unittest.cc
+++ b/components/domain_reliability/monitor_unittest.cc
@@ -339,23 +339,6 @@ TEST_F(DomainReliabilityMonitorTest, ClearContexts) {
EXPECT_EQ(0u, monitor_.contexts_size_for_testing());
}
-// TODO(davidben): When https://crbug.com/490311 is resolved, this test can be
-// removed.
-TEST_F(DomainReliabilityMonitorTest, IgnoreSuccessError) {
- RequestInfo request = MakeRequestInfo();
- request.url = GURL("http://example/always_report");
- request.status = net::URLRequestStatus(net::URLRequestStatus::SUCCESS,
- net::ERR_QUIC_PROTOCOL_ERROR);
- OnRequestLegComplete(request);
-
- BeaconVector beacons;
- context_->GetQueuedBeaconsForTesting(&beacons);
- EXPECT_EQ(1u, beacons.size());
- EXPECT_EQ(net::OK, beacons[0].chrome_error);
-
- EXPECT_TRUE(CheckRequestCounts(kAlwaysReportIndex, 1u, 0u));
-}
-
TEST_F(DomainReliabilityMonitorTest, WildcardMatchesSelf) {
DomainReliabilityContext* context = CreateAndAddContext("*.wildcard");

Powered by Google App Engine
This is Rietveld 408576698