chromeos/login/auth/mock_url_fetchers.cc - Issue 1239993004: Fix all failed and canceled URLRequestStatuses without errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/login/auth/mock_url_fetchers.cc

Issue 1239993004: Fix all failed and canceled URLRequestStatuses without errors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix more failures Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/supervised_user/experimental/supervised_user_async_url_checker_unittest.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromeos/login/auth/mock_url_fetchers.cc

diff --git a/chromeos/login/auth/mock_url_fetchers.cc b/chromeos/login/auth/mock_url_fetchers.cc

index 490f56bac2462c87a5513e255661e79078eb4689..0b4879bc79fee96a402c73ac5c6fb927472fba85 100644

--- a/chromeos/login/auth/mock_url_fetchers.cc

+++ b/chromeos/login/auth/mock_url_fetchers.cc

@@ -11,6 +11,7 @@

#include "base/single_thread_task_runner.h"

#include "base/strings/stringprintf.h"

#include "base/thread_task_runner_handle.h"

+#include "net/base/net_errors.h"

#include "net/http/http_status_code.h"

#include "net/url_request/url_fetcher.h"

#include "net/url_request/url_fetcher_delegate.h"

@@ -50,7 +51,7 @@ GotCanceledFetcher::GotCanceledFetcher(

net::URLFetcherDelegate* d)

: net::TestURLFetcher(0, url, d) {

set_url(url);

- set_status(net::URLRequestStatus(net::URLRequestStatus::CANCELED, 0));

+ set_status(net::URLRequestStatus::FromError(net::ERR_ABORTED));

set_response_code(net::HTTP_FORBIDDEN);

}

@@ -86,7 +87,7 @@ FailFetcher::FailFetcher(bool success,

net::URLFetcherDelegate* d)

: net::TestURLFetcher(0, url, d) {

set_url(url);

- set_status(net::URLRequestStatus(net::URLRequestStatus::FAILED, ECONNRESET));

+ set_status(net::URLRequestStatus::FromError(net::ERR_CONNECTION_RESET));

set_response_code(net::HTTP_OK);

}