Make CSSCalcValue work with CSSParserTokenRange

Source/core/css/parser/CSSParserValues.cpp

 /*
  * Copyright (C) 2003 Lars Knoll (knoll@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2008 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
@@ skipping 22 matching lines @@
 using namespace WTF;
 
 CSSParserValueList::CSSParserValueList(CSSParserTokenRange range, bool& usesRemUnits)
 : m_current(0)
 {
     usesRemUnits = false;
     Vector<CSSParserValueList*> stack;
     Vector<int> bracketCounts;
     stack.append(this);
     bracketCounts.append(0);
-    unsigned calcDepth = 0;
     while (!range.atEnd()) {
         ASSERT(stack.size() == bracketCounts.size());
         ASSERT(!stack.isEmpty());
-        const CSSParserToken& token = range.consume();
+        const CSSParserToken& token = range.peek();
+        if (token.type() != FunctionToken)
+            range.consume();
         CSSParserValue value;
         switch (token.type()) {
         case FunctionToken: {
             if (token.valueEqualsIgnoringCase("url")) {
+                range.consume();
                 const CSSParserToken& next = range.consumeIncludingWhitespace();
                 if (next.type() == BadStringToken || range.consume().type() != RightParenthesisToken) {
                     destroyAndClear();
                     return;
                 }
                 ASSERT(next.type() == StringToken);
                 value.id = CSSValueInvalid;
                 value.isInt = false;
                 value.unit = CSSPrimitiveValue::CSS_URI;
                 value.string = next.value();
                 break;
             }
 
+            value.id = CSSValueInvalid;
+            value.isInt = false;
+
+            CSSValueID id = cssValueKeywordID(token.value());
+            if (id == CSSValueCalc || id == CSSValueWebkitCalc) {
+                value.unit = CSSParserValue::CalcFunction;
+                // FIXME: calc expression could contain REM units

[Timothy Loh, 2015/07/29 03:52:04]

We.. probably shouldn't intentionally add regressions like this. Are we going to
fix this straight away? :)

[rwlbuis, 2015/07/29 21:33:26]

Good point :) I am picking up the rem patch again.

+                value.calcFunction = new CSSParserCalcFunction(range.consumeBlock());
+                break;
+            }
+            range.consume();
+            value.unit = CSSParserValue::Function;
             CSSParserFunction* function = new CSSParserFunction;
-            function->id = cssValueKeywordID(token.value());
+            function->id = id;
             CSSParserValueList* list = new CSSParserValueList;
             function->args = adoptPtr(list);
 
-            value.id = CSSValueInvalid;
-            value.isInt = false;
-            value.unit = CSSParserValue::Function;
             value.function = function;
 
             stack.last()->addValue(value);
             stack.append(list);
             bracketCounts.append(0);
-            calcDepth += (function->id == CSSValueCalc || function->id == CSSValueWebkitCalc);
             continue;
         }
         case LeftParenthesisToken: {
-            if (calcDepth == 0) {
-                CSSParserValueList* list = new CSSParserValueList;
-                value.setFromValueList(adoptPtr(list));
-                stack.last()->addValue(value);
-                stack.append(list);
-                bracketCounts.append(0);
-                continue;
-            }
-            bracketCounts.last()++;
-            value.setFromOperator('(');
-            break;
+            CSSParserValueList* list = new CSSParserValueList;
+            value.setFromValueList(adoptPtr(list));
+            stack.last()->addValue(value);
+            stack.append(list);
+            bracketCounts.append(0);
+            continue;
         }
         case RightParenthesisToken: {
             if (bracketCounts.last() == 0) {
                 stack.removeLast();
                 bracketCounts.removeLast();
                 if (bracketCounts.isEmpty()) {
                     destroyAndClear();
                     return;
                 }
-                CSSParserValueList* currentList = stack.last();
-                CSSParserValue* current = currentList->valueAt(currentList->size()-1);
-                if (current->unit == CSSParserValue::Function) {
-                    CSSValueID id = current->function->id;
-                    calcDepth -= (id == CSSValueCalc || id == CSSValueWebkitCalc);
-                }
                 continue;
             }
-            ASSERT(calcDepth > 0);
             bracketCounts.last()--;
             value.setFromOperator(')');
             break;
         }
         case IdentToken: {
             value.id = cssValueKeywordID(token.value());
             value.isInt = false;
             value.unit = CSSPrimitiveValue::CSS_IDENT;
             value.string = token.value();
             break;
@@ skipping 51 matching lines @@
                 value.unit = CSSParserValue::HexColor;
             else if (token.type() == StringToken)
                 value.unit = CSSPrimitiveValue::CSS_STRING;
             else
                 value.unit = CSSPrimitiveValue::CSS_URI;
             value.string = token.value();
             break;
         }
         case DelimiterToken:
             value.setFromOperator(token.delimiter());
-            if (calcDepth && token.delimiter() == '+' && (&token - 1)->type() != WhitespaceToken) {
-                // calc(1px+ 2px) is invalid
-                destroyAndClear();
-                return;
-            }
             break;
         case CommaToken:
             value.setFromOperator(',');
             break;
         case LeftBracketToken:
             value.setFromOperator('[');
             break;
         case RightBracketToken:
             value.setFromOperator(']');
             break;
@@ skipping 38 matching lines @@
         bracketCounts.removeLast();
     }
 }
 
 static void destroy(Vector<CSSParserValue, 4>& values)
 {
     size_t numValues = values.size();
     for (size_t i = 0; i < numValues; i++) {
         if (values[i].unit == CSSParserValue::Function)
             delete values[i].function;
+        else if (values[i].unit == CSSParserValue::CalcFunction)
+            delete values[i].calcFunction;
         else if (values[i].unit == CSSParserValue::ValueList
             || values[i].unit == CSSParserValue::DimensionList)
             delete values[i].valueList;
     }
 }
 
 void CSSParserValueList::destroyAndClear()
 {
     destroy(m_values);
     clearAndLeakValues();
@@ skipping 96 matching lines @@
 bool CSSParserSelector::hasHostPseudoSelector() const
 {
     for (CSSParserSelector* selector = const_cast<CSSParserSelector*>(this); selector; selector = selector->tagHistory()) {
         if (selector->pseudoType() == CSSSelector::PseudoHost || selector->pseudoType() == CSSSelector::PseudoHostContext)
             return true;
     }
     return false;
 }
 
 } // namespace blink