Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1239963002: Split llvm_coverage_run into two scripts (Closed)

Created:
5 years, 5 months ago by borenet
Modified:
5 years, 5 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Split llvm_coverage_run into two scripts ... One for running to generate the coverage data, another to parse the data into various formats. NOTRY=true BUG=skia:2430 Committed: https://skia.googlesource.com/skia/+/a6ae14e2232a46fbc3baed74e2581dde119e7f1e

Patch Set 1 #

Patch Set 2 : Split into two scripts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+207 lines, -132 lines) Patch
M tools/llvm_coverage_run.py View 1 4 chunks +6 lines, -132 lines 0 comments Download
A tools/parse_llvm_coverage.py View 1 1 chunk +201 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
borenet
This is a cleaner division of concerns.
5 years, 5 months ago (2015-07-17 18:35:24 UTC) #2
mtklein
lgtm
5 years, 5 months ago (2015-07-17 19:29:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1239963002/20001
5 years, 5 months ago (2015-07-20 16:43:02 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-20 16:43:39 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/a6ae14e2232a46fbc3baed74e2581dde119e7f1e

Powered by Google App Engine
This is Rietveld 408576698