Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 1239943003: Make sure GN deps rolls include the optional GN bots. (Closed)

Created:
5 years, 5 months ago by Dirk Pranke
Modified:
5 years, 5 months ago
Reviewers:
brettw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make sure GN deps rolls include the optional GN bots. Some of the GN tryservers are not yet part of the default CQ set of bots, but we should be sure to run them anyway on deps rolls that pull in new GN binaries. R=brettw@chromium.org BUG= Committed: https://crrev.com/45884a2d5e69332baeaec2f3e969ecd464b2a627 Cr-Commit-Position: refs/heads/master@{#339749}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M tools/gn/bin/roll_gn.py View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Dirk Pranke
5 years, 5 months ago (2015-07-21 02:34:00 UTC) #1
brettw
lgtm
5 years, 5 months ago (2015-07-21 16:27:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1239943003/1
5 years, 5 months ago (2015-07-21 21:02:31 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-21 21:16:42 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 21:17:36 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/45884a2d5e69332baeaec2f3e969ecd464b2a627
Cr-Commit-Position: refs/heads/master@{#339749}

Powered by Google App Engine
This is Rietveld 408576698