Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1239873002: Re-ship harmony spread calls and spread arrays (Closed)

Created:
5 years, 5 months ago by adamk
Modified:
5 years, 5 months ago
Reviewers:
rossberg
CC:
v8-dev, caitp (gmail)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Re-ship harmony spread calls and spread arrays The issue with spread arrays which caused us to turn it off was fixed in https://chromium.googlesource.com/v8/v8/+/24e98281 BUG=v8:3018 LOG=y Committed: https://crrev.com/bd389ec008e0cd2bfa3065ebb1bbe3f44d50cb99 Cr-Commit-Position: refs/heads/master@{#29713}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M src/flag-definitions.h View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
adamk
5 years, 5 months ago (2015-07-15 19:57:09 UTC) #2
rossberg
lgtm
5 years, 5 months ago (2015-07-16 11:26:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1239873002/1
5 years, 5 months ago (2015-07-16 16:46:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-16 19:44:35 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-16 19:44:51 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bd389ec008e0cd2bfa3065ebb1bbe3f44d50cb99
Cr-Commit-Position: refs/heads/master@{#29713}

Powered by Google App Engine
This is Rietveld 408576698