cc: Call PrepareTiles when becoming visible in browser only.

cc: Call PrepareTiles when becoming visible in browser only.

Calling PrepareTiles on each visibility change might have caused a v8
idle time benchmark regression. We only need to call PrepareTiles for
the SingleThreadProxy wait for ready to draw mode.

R=brianderson@chromium.org,danakj@chromium.org
TEST=LayerTreeHostTestReadyToDrawVisibility
BUG=499040
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/c67e9d831fa3753fc5434229d3275b1c0155edae
Cr-Commit-Position: refs/heads/master@{#339201}

[sunnyps, 2015-07-15 18:14:57]

PTAL

[sunnyps, 2015-07-15 18:26:13]

Please ignore for now - I want to add a better test for this.

[sunnyps, 2015-07-16 21:28:45]

PTAL

Added a LayerTreeTest which fails without the extra PrepareTiles call

[brianderson, 2015-07-16 22:36:14]

lgtm

https://codereview.chromium.org/1239843002/diff/20001/cc/trees/layer_tree_hos...
File cc/trees/layer_tree_host_unittest.cc (right):

https://codereview.chromium.org/1239843002/diff/20001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_unittest.cc:275: class
LayerTreeHostTestReadyToDrawVisibility
Can you add a comment explaining what this test does an why.

https://codereview.chromium.org/1239843002/diff/20001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_unittest.cc:291: PostSetVisibleToMainThread(true);
To test the test, could you:
DCHECK(!all_tiles_required_for_draw_are_ready_to_draw_)
here?

[sunnyps, 2015-07-16 22:51:44]

https://codereview.chromium.org/1239843002/diff/20001/cc/trees/layer_tree_hos...
File cc/trees/layer_tree_host_unittest.cc (right):

https://codereview.chromium.org/1239843002/diff/20001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_unittest.cc:275: class
LayerTreeHostTestReadyToDrawVisibility
On 2015/07/16 22:36:14, brianderson wrote:
> Can you add a comment explaining what this test does an why. 

Done.

https://codereview.chromium.org/1239843002/diff/20001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_unittest.cc:291: PostSetVisibleToMainThread(true);
On 2015/07/16 22:36:14, brianderson wrote:
> To test the test, could you:
> DCHECK(!all_tiles_required_for_draw_are_ready_to_draw_)
> here?

Done.

[sunnyps, 2015-07-16 22:52:03]

The CQ bit was checked by sunnyps@chromium.org

[sunnyps, 2015-07-16 22:52:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
brianderson@chromium.org
Link to the patchset: https://codereview.chromium.org/1239843002/#ps40001
(title: "brianderson's review")

[commit-bot: I haz the power, 2015-07-16 22:55:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1239843002/40001

[sunnyps, 2015-07-16 23:31:26]

The CQ bit was checked by sunnyps@chromium.org

[sunnyps, 2015-07-16 23:31:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
brianderson@chromium.org
Link to the patchset: https://codereview.chromium.org/1239843002/#ps60001
(title: "Fix compile error - size_t infects everything!")

[commit-bot: I haz the power, 2015-07-16 23:35:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1239843002/60001

[commit-bot: I haz the power, 2015-07-17 00:09:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-17 00:09:38]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[sunnyps, 2015-07-17 01:20:55]

The CQ bit was checked by sunnyps@chromium.org

[commit-bot: I haz the power, 2015-07-17 01:21:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1239843002/60001

[commit-bot: I haz the power, 2015-07-17 02:02:24]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-07-17 02:03:21]

Patchset 4 (id:??) landed as
https://crrev.com/c67e9d831fa3753fc5434229d3275b1c0155edae
Cr-Commit-Position: refs/heads/master@{#339201}

[Jeffrey Yasskin, 2015-07-20 19:05:35]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1239363003/ by jyasskin@chromium.org.

The reason for reverting is: LayerTreeHostTestReadyToDrawVisibility times out
under DrMemory:
http://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28...

[----------] 2 tests from LayerTreeHostTestReadyToDrawVisibility
[ RUN      ]
LayerTreeHostTestReadyToDrawVisibility.RunSingleThread_DirectRenderer
c:\b\build\slave\drm-cr\build\src\cc\test\layer_tree_test.cc(875): error: Failed
Test timed out
[  FAILED  ]
LayerTreeHostTestReadyToDrawVisibility.RunSingleThread_DirectRenderer (5044 ms)
[ RUN      ]
LayerTreeHostTestReadyToDrawVisibility.RunSingleThread_DelegatingRenderer
c:\b\build\slave\drm-cr\build\src\cc\test\layer_tree_test.cc(875): error: Failed
Test timed out
[  FAILED  ]
LayerTreeHostTestReadyToDrawVisibility.RunSingleThread_DelegatingRenderer (5244
ms)
[----------] 2 tests from LayerTreeHostTestReadyToDrawVisibility (10292 ms
total).