Issue 1239803005: fix issues caught by analysis_server

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1239803005: fix issues caught by analysis_server (Closed)

Created:
5 years, 5 months ago by Jennifer Messerly

Modified:
5 years, 5 months ago

Reviewers:
vsm

CC:
dev-compiler+reviews_dartlang.org

Base URL:
git@github.com:dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

analyzer fixes found these in the "dart analysis" tool window (after excluding test files and such) R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/ea507d12b371d3ff92d640b0ec4efe40da9f8ddc

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -11 lines)			Patch
M	bin/edit_files.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	lib/runtime/messages_widget.dart	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	test/checker/self_host_test.dart	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	test/codegen_test.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	test/dependency_graph_test.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tool/patch_sdk.dart	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 4 (1 generated)

Jennifer Messerly

5 years, 5 months ago (2015-07-15 17:00:21 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ea507d12b371d3ff92d640b0ec4efe40da9f8ddc (presubmit successful).