Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1239803002: llvm-coverage script: respect SKIA_OUT (Closed)

Created:
5 years, 5 months ago by borenet
Modified:
5 years, 5 months ago
Reviewers:
rmistry, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

llvm-coverage script: respect SKIA_OUT NOTRY=true BUG=skia:2430 Committed: https://skia.googlesource.com/skia/+/f0c84407ae12e0483af26881ec9e22de97563fef

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M tools/llvm_coverage_run.py View 1 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
borenet
5 years, 5 months ago (2015-07-15 14:24:07 UTC) #2
mtklein
lgtm as is, but i think we can cut 5-10 lines of code... https://codereview.chromium.org/1239803002/diff/1/tools/llvm_coverage_run.py File ...
5 years, 5 months ago (2015-07-15 14:30:46 UTC) #3
borenet
https://codereview.chromium.org/1239803002/diff/1/tools/llvm_coverage_run.py File tools/llvm_coverage_run.py (right): https://codereview.chromium.org/1239803002/diff/1/tools/llvm_coverage_run.py#newcode73 tools/llvm_coverage_run.py:73: if os.environ.get(SKIA_OUT): On 2015/07/15 14:30:46, mtklein wrote: > I ...
5 years, 5 months ago (2015-07-15 14:42:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1239803002/20001
5 years, 5 months ago (2015-07-15 14:42:36 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-15 14:43:09 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/f0c84407ae12e0483af26881ec9e22de97563fef

Powered by Google App Engine
This is Rietveld 408576698