Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2371)

Unified Diff: chrome/installer/setup/install.h

Issue 12398024: Do not try to make Chrome default when registering it if it can't be made default unattended. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/installer/setup/install.cc » ('j') | chrome/installer/setup/install.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/setup/install.h
diff --git a/chrome/installer/setup/install.h b/chrome/installer/setup/install.h
index 4ce974b5c0026f4d4578f59f72144dfa956d59d1..70ae28582ebbd179b613ccef87938808225ab598 100644
--- a/chrome/installer/setup/install.h
+++ b/chrome/installer/setup/install.h
@@ -80,10 +80,11 @@ void CreateOrUpdateShortcuts(
InstallShortcutOperation install_operation);
// Registers Chrome on this machine.
-// If |make_chrome_default|, also attempts to make Chrome default (potentially
-// popping a UAC if the user is not an admin and HKLM registrations are required
-// to register Chrome's capabilities on this version of Windows (i.e.
-// pre-Win8)).
+// If |make_chrome_default|, also attempts to make Chrome default.
grt (UTC plus 2) 2013/03/05 03:27:10 is this shorter form correct? // If |make_chrome_d
gab 2013/03/05 16:29:32 Much better :)!
+// |make_chrome_default| is ignored if Chrome can't be made default unattended
+// (except if the only user action required is to accept a UAC; e.g., if the
+// user is not an admin and HKLM registrations are required to register Chrome's
+// capabilities on this version of Windows (i.e. pre-Win8)).
void RegisterChromeOnMachine(const InstallerState& installer_state,
const Product& product,
bool make_chrome_default);
« no previous file with comments | « no previous file | chrome/installer/setup/install.cc » ('j') | chrome/installer/setup/install.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698