Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Side by Side Diff: src/x64/code-stubs-x64.cc

Issue 12398011: Also fix cast warnings on Win64 (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/x64/macro-assembler-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 6243 matching lines...) Expand 10 before | Expand all | Expand 10 after
6254 // Check for the hole and skip. 6254 // Check for the hole and skip.
6255 __ CompareRoot(entity_name, Heap::kTheHoleValueRootIndex); 6255 __ CompareRoot(entity_name, Heap::kTheHoleValueRootIndex);
6256 __ j(equal, &good, Label::kNear); 6256 __ j(equal, &good, Label::kNear);
6257 6257
6258 // Check if the entry name is not a unique name. 6258 // Check if the entry name is not a unique name.
6259 __ movq(entity_name, FieldOperand(entity_name, HeapObject::kMapOffset)); 6259 __ movq(entity_name, FieldOperand(entity_name, HeapObject::kMapOffset));
6260 __ testb(FieldOperand(entity_name, Map::kInstanceTypeOffset), 6260 __ testb(FieldOperand(entity_name, Map::kInstanceTypeOffset),
6261 Immediate(kIsInternalizedMask)); 6261 Immediate(kIsInternalizedMask));
6262 __ j(not_zero, &good, Label::kNear); 6262 __ j(not_zero, &good, Label::kNear);
6263 __ cmpb(FieldOperand(entity_name, Map::kInstanceTypeOffset), 6263 __ cmpb(FieldOperand(entity_name, Map::kInstanceTypeOffset),
6264 Immediate(static_cast<int8_t>(SYMBOL_TYPE))); 6264 Immediate(static_cast<uint8_t>(SYMBOL_TYPE)));
6265 __ j(not_equal, miss); 6265 __ j(not_equal, miss);
6266 6266
6267 __ bind(&good); 6267 __ bind(&good);
6268 } 6268 }
6269 6269
6270 NameDictionaryLookupStub stub(properties, r0, r0, NEGATIVE_LOOKUP); 6270 NameDictionaryLookupStub stub(properties, r0, r0, NEGATIVE_LOOKUP);
6271 __ Push(Handle<Object>(name)); 6271 __ Push(Handle<Object>(name));
6272 __ push(Immediate(name->Hash())); 6272 __ push(Immediate(name->Hash()));
6273 __ CallStub(&stub); 6273 __ CallStub(&stub);
6274 __ testq(r0, r0); 6274 __ testq(r0, r0);
(...skipping 113 matching lines...) Expand 10 before | Expand all | Expand 10 after
6388 // lookup we have to bailout as this key might be equal to the 6388 // lookup we have to bailout as this key might be equal to the
6389 // key we are looking for. 6389 // key we are looking for.
6390 6390
6391 // Check if the entry name is not a unique name. 6391 // Check if the entry name is not a unique name.
6392 Label cont; 6392 Label cont;
6393 __ movq(scratch, FieldOperand(scratch, HeapObject::kMapOffset)); 6393 __ movq(scratch, FieldOperand(scratch, HeapObject::kMapOffset));
6394 __ testb(FieldOperand(scratch, Map::kInstanceTypeOffset), 6394 __ testb(FieldOperand(scratch, Map::kInstanceTypeOffset),
6395 Immediate(kIsInternalizedMask)); 6395 Immediate(kIsInternalizedMask));
6396 __ j(not_zero, &cont); 6396 __ j(not_zero, &cont);
6397 __ cmpb(FieldOperand(scratch, Map::kInstanceTypeOffset), 6397 __ cmpb(FieldOperand(scratch, Map::kInstanceTypeOffset),
6398 Immediate(static_cast<int8_t>(SYMBOL_TYPE))); 6398 Immediate(static_cast<uint8_t>(SYMBOL_TYPE)));
6399 __ j(not_equal, &maybe_in_dictionary); 6399 __ j(not_equal, &maybe_in_dictionary);
6400 __ bind(&cont); 6400 __ bind(&cont);
6401 } 6401 }
6402 } 6402 }
6403 6403
6404 __ bind(&maybe_in_dictionary); 6404 __ bind(&maybe_in_dictionary);
6405 // If we are doing negative lookup then probing failure should be 6405 // If we are doing negative lookup then probing failure should be
6406 // treated as a lookup success. For positive lookup probing failure 6406 // treated as a lookup success. For positive lookup probing failure
6407 // should be treated as lookup failure. 6407 // should be treated as lookup failure.
6408 if (mode_ == POSITIVE_LOOKUP) { 6408 if (mode_ == POSITIVE_LOOKUP) {
(...skipping 472 matching lines...) Expand 10 before | Expand all | Expand 10 after
6881 #endif 6881 #endif
6882 6882
6883 __ Ret(); 6883 __ Ret();
6884 } 6884 }
6885 6885
6886 #undef __ 6886 #undef __
6887 6887
6888 } } // namespace v8::internal 6888 } } // namespace v8::internal
6889 6889
6890 #endif // V8_TARGET_ARCH_X64 6890 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « no previous file | src/x64/macro-assembler-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698