Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 12398010: Add workaround for redefinition of __proto__ property. (Closed)

Created:
7 years, 9 months ago by Michael Starzinger
Modified:
7 years, 9 months ago
Reviewers:
rossberg
CC:
v8-dev
Visibility:
Public.

Description

Add workaround for redefinition of __proto__ property. This is a temporary workaround when the __proto__ property is being redefined (e.g. by Object.freeze()) to not loose the foreign callback. Once the __proto__ property is a real JavaScript accessor this hack is no longer necessary. This change also makes __proto__ configurable. R=rossberg@chromium.org BUG=v8:2565 TEST=mjsunit/regress/regress-2565 Committed: http://code.google.com/p/v8/source/detail?r=13817

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments by Andreas Rossberg. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -9 lines) Patch
M src/bootstrapper.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/runtime.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-2565.js View 1 chunk +5 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Michael Starzinger
7 years, 9 months ago (2013-03-04 15:51:27 UTC) #1
rossberg
https://codereview.chromium.org/12398010/diff/1/src/runtime.cc File src/runtime.cc (right): https://codereview.chromium.org/12398010/diff/1/src/runtime.cc#newcode4099 src/runtime.cc:4099: attr = static_cast<PropertyAttributes>(attr & ~READ_ONLY); As discussed offline, this ...
7 years, 9 months ago (2013-03-04 16:04:42 UTC) #2
Michael Starzinger
Comments addressed. PTAL. https://codereview.chromium.org/12398010/diff/1/src/runtime.cc File src/runtime.cc (right): https://codereview.chromium.org/12398010/diff/1/src/runtime.cc#newcode4099 src/runtime.cc:4099: attr = static_cast<PropertyAttributes>(attr & ~READ_ONLY); On ...
7 years, 9 months ago (2013-03-04 16:24:58 UTC) #3
rossberg
lgtm
7 years, 9 months ago (2013-03-04 17:31:14 UTC) #4
Michael Starzinger
7 years, 9 months ago (2013-03-04 17:53:47 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r13817 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698