Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Unified Diff: net/proxy/proxy_resolver_v8.cc

Issue 12398007: Replaced deprecated v8 API calls by their non-deprecated counterparts. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed first round of feedback Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/proxy/proxy_resolver_v8.cc
diff --git a/net/proxy/proxy_resolver_v8.cc b/net/proxy/proxy_resolver_v8.cc
index c28dead6ce0036505a94ae9b0930bad937c497d1..8a993ad65653a71cf26ef0fa08d853fc5e30d1f5 100644
--- a/net/proxy/proxy_resolver_v8.cc
+++ b/net/proxy/proxy_resolver_v8.cc
@@ -736,4 +736,9 @@ v8::Isolate* ProxyResolverV8::GetDefaultIsolate() {
v8::Isolate* ProxyResolverV8::g_default_isolate_ = NULL;
+// static
+void ProxyResolverV8::GetHeapStatistics(v8::HeapStatistics* heap_statistics) {
+ GetDefaultIsolate()->GetHeapStatistics(heap_statistics);
eroman 2013/03/05 00:40:45 I think this should be prepared to handle the case
Sven Panne 2013/03/05 07:22:39 Good point, I'll handle that case by zero-ing out
Sven Panne 2013/03/05 07:32:05 I was a bit too quick here: One can't modify HeapS
Sven Panne 2013/03/05 08:34:31 After talking to Jochen and re-thinking things aga
+}
+
} // namespace net

Powered by Google App Engine
This is Rietveld 408576698