Replaced deprecated v8 API calls by their non-deprecated counterparts.

net/proxy/proxy_resolver_v8.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/proxy/proxy_resolver_v8.h"
 
 #include <algorithm>
 #include <cstdio>
 
 #include "base/basictypes.h"
@@ skipping 718 matching lines @@
 
 // static
 v8::Isolate* ProxyResolverV8::GetDefaultIsolate() {
   DCHECK(g_default_isolate_)
       << "Must call ProxyResolverV8::RememberDefaultIsolate() first";
   return g_default_isolate_;
 }
 
 v8::Isolate* ProxyResolverV8::g_default_isolate_ = NULL;
 
+// static
+void ProxyResolverV8::GetHeapStatistics(v8::HeapStatistics* heap_statistics) {
+  GetDefaultIsolate()->GetHeapStatistics(heap_statistics);

[eroman, 2013/03/05 00:40:45]

I think this should be prepared to handle the case where GetDefaultIsolate()
returns NULL, rather than crash.

My recommendation is to return 0 in that case (after removing the
heap_statistics parameter).

[Sven Panne, 2013/03/05 07:22:39]

Good point, I'll handle that case by zero-ing out the HeapStatistics (see other
comments).

[Sven Panne, 2013/03/05 07:32:05]

I was a bit too quick here: One can't modify HeapStatistics (we have to re-think
that), but we can handle things in a consistent way here, anyway: The
HeapStatistics constructor already zeroes out everything, so being a no-op in
the case of no Isolate is fine.

[Sven Panne, 2013/03/05 08:34:31]

After talking to Jochen and re-thinking things again, I think I'll follow Eric's
suggestions. Furthermore, I'll add a function for adding up heap statistics
(instead of getting them only), but this is unrelated to this CL at hand.

+}
+
 }  // namespace net