Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/compiler/interpreter-assembler.cc

Issue 1239793002: [interpreter] Add basic framework for bytecode handler code generation. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Add tests Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "src/compiler/interpreter-assembler.h"
6
7 #include <ostream>
8
9 #include "src/compiler/graph.h"
10 #include "src/compiler/instruction-selector.h"
11 #include "src/compiler/linkage.h"
12 #include "src/compiler/machine-type.h"
13 #include "src/compiler/pipeline.h"
14 #include "src/compiler/raw-machine-assembler.h"
15 #include "src/compiler/schedule.h"
16 #include "src/frames.h"
17 #include "src/interpreter/bytecodes.h"
18 #include "src/macro-assembler.h"
19 #include "src/zone.h"
20
21 namespace v8 {
22 namespace internal {
23 namespace compiler {
24
25
26 InterpreterAssembler::InterpreterAssembler(Isolate* isolate, Zone* zone,
27 interpreter::Bytecode bytecode)
28 : bytecode_(bytecode),
29 raw_assembler_(new RawMachineAssembler(
30 isolate, new (zone) Graph(zone),
31 Linkage::GetInterpreterDispatchDescriptor(zone), kMachPtr,
32 InstructionSelector::SupportedMachineOperatorFlags())),
33 end_node_(nullptr),
34 code_generated_(false) {}
35
36
37 InterpreterAssembler::~InterpreterAssembler() {}
38
39
40 Handle<Code> InterpreterAssembler::GenerateCode() {
41 DCHECK(!code_generated_);
42
43 End();
44
45 Schedule* schedule = raw_assembler_->Export();
46 // TODO(rmcilroy): use a non-testing code generator.
47 Handle<Code> code = Pipeline::GenerateCodeForTesting(
48 isolate(), raw_assembler_->call_descriptor(), graph(), schedule);
49
50 #ifdef ENABLE_DISASSEMBLER
51 if (FLAG_trace_ignition_codegen) {
52 OFStream os(stdout);
53 code->Disassemble(interpreter::Bytecodes::ToString(bytecode_), os);
54 os << std::flush;
55 }
56 #endif
57
58 code_generated_ = true;
59 return code;
60 }
61
62
63 Node* InterpreterAssembler::BytecodePointer() {
64 return raw_assembler_->Parameter(Linkage::kInterpreterBytecodeParameter);
65 }
66
67
68 Node* InterpreterAssembler::DispatchTablePointer() {
69 return raw_assembler_->Parameter(Linkage::kInterpreterDispatchTableParameter);
70 }
71
72
73 Node* InterpreterAssembler::FramePointer() {
74 return raw_assembler_->LoadFramePointer();
75 }
76
77
78 Node* InterpreterAssembler::RegisterFrameOffset(int index) {
79 DCHECK_LE(index, kMaxRegisterIndex);
80 return Int32Constant(kFirstRegsterOffsetFromFp - (index << kPointerSizeLog2));
81 }
82
83
84 Node* InterpreterAssembler::RegisterFrameOffset(Node* index) {
85 return raw_assembler_->Int32Sub(
86 Int32Constant(kFirstRegsterOffsetFromFp),
87 raw_assembler_->Word32Shl(index, Int32Constant(kPointerSizeLog2)));
88 }
89
90
91 Node* InterpreterAssembler::BytecodeArg(int delta) {
92 DCHECK_LT(delta, interpreter::Bytecodes::NumberOfArguments(bytecode_));
93 return raw_assembler_->Load(kMachUint8, BytecodePointer(),
94 Int32Constant(1 + delta));
95 }
96
97
98 Node* InterpreterAssembler::LoadRegister(int index) {
99 return raw_assembler_->Load(kMachPtr, FramePointer(),
100 RegisterFrameOffset(index));
101 }
102
103
104 Node* InterpreterAssembler::LoadRegister(Node* index) {
105 return raw_assembler_->Load(kMachPtr, FramePointer(),
106 RegisterFrameOffset(index));
107 }
108
109
110 Node* InterpreterAssembler::StoreRegister(Node* value, int index) {
111 return raw_assembler_->Store(kMachPtr, FramePointer(),
112 RegisterFrameOffset(index), value);
113 }
114
115
116 Node* InterpreterAssembler::StoreRegister(Node* value, Node* index) {
117 return raw_assembler_->Store(kMachPtr, FramePointer(),
118 RegisterFrameOffset(index), value);
119 }
120
121
122 Node* InterpreterAssembler::Advance(int delta) {
123 return raw_assembler_->IntPtrAdd(BytecodePointer(), Int32Constant(delta));
124 }
125
126
127 void InterpreterAssembler::Dispatch() {
128 Node* new_bytecode_pointer = Advance(interpreter::Bytecodes::Size(bytecode_));
129 Node* target_bytecode =
130 raw_assembler_->Load(kMachUint8, new_bytecode_pointer);
131
132 // TODO(rmcilroy): Create a code target dispatch table to avoid conversion
133 // from code object on every dispatch.
134 Node* target_code_object = raw_assembler_->Load(
135 kMachPtr, DispatchTablePointer(),
136 raw_assembler_->Word32Shl(target_bytecode,
137 Int32Constant(kPointerSizeLog2)));
138
139 // If the order of the parameters you need to change the call signature below.
140 STATIC_ASSERT(0 == Linkage::kInterpreterBytecodeParameter);
141 STATIC_ASSERT(1 == Linkage::kInterpreterDispatchTableParameter);
142 Node* tail_call = graph()->NewNode(common()->TailCall(call_descriptor()),
143 target_code_object, new_bytecode_pointer,
144 DispatchTablePointer(), graph()->start(),
145 graph()->start());
146 schedule()->AddTailCall(raw_assembler_->CurrentBlock(), tail_call);
147
148 // This should always be the end node.
149 SetEndInput(tail_call);
150 }
151
152
153 void InterpreterAssembler::SetEndInput(Node* input) {
154 DCHECK(!end_node_);
155 end_node_ = input;
156 }
157
158
159 void InterpreterAssembler::End() {
160 DCHECK(end_node_);
161 // TODO(rmcilroy): Support more than 1 end input.
162 Node* end = graph()->NewNode(common()->End(1), end_node_);
163 graph()->SetEnd(end);
164 }
165
166
167 // RawMachineAssembler delegate helpers:
168 Isolate* InterpreterAssembler::isolate() { return raw_assembler_->isolate(); }
169
170
171 Graph* InterpreterAssembler::graph() { return raw_assembler_->graph(); }
172
173
174 CallDescriptor* InterpreterAssembler::call_descriptor() const {
175 return raw_assembler_->call_descriptor();
176 }
177
178
179 Schedule* InterpreterAssembler::schedule() {
180 return raw_assembler_->schedule();
181 }
182
183
184 MachineOperatorBuilder* InterpreterAssembler::machine() {
185 return raw_assembler_->machine();
186 }
187
188
189 CommonOperatorBuilder* InterpreterAssembler::common() {
190 return raw_assembler_->common();
191 }
192
193
194 Node* InterpreterAssembler::Int32Constant(int value) {
195 return raw_assembler_->Int32Constant(value);
196 }
197
198
199 Node* InterpreterAssembler::NumberConstant(double value) {
200 return raw_assembler_->NumberConstant(value);
201 }
202
203
204 } // namespace interpreter
205 } // namespace internal
206 } // namespace v8
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698