Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Issue 1239783002: Multicol performance tests for tall content (so that we get (very) many columns). (Closed)

Created:
5 years, 5 months ago by mstensho (USE GERRIT)
Modified:
5 years, 5 months ago
Reviewers:
dsinclair
CC:
blink-reviews
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Multicol performance tests for tall content (so that we get (very) many columns). This is currently horribly slow. Discovered while working on bug 502407 (assertion failure). It seems impossible to write a test for that issue that doesn't run into the performance problems illustrated by these tests, so we have to land some performance improvements before fixing the actual assertion. R=dsinclair@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198956

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -0 lines) Patch
A PerformanceTests/Layout/multicol/tall-content-short-columns.html View 1 chunk +28 lines, -0 lines 0 comments Download
A PerformanceTests/Layout/multicol/tall-content-short-columns-realistic.html View 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
mstensho (USE GERRIT)
5 years, 5 months ago (2015-07-15 10:15:43 UTC) #1
dsinclair
lgtm
5 years, 5 months ago (2015-07-15 13:49:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1239783002/1
5 years, 5 months ago (2015-07-15 13:49:26 UTC) #4
commit-bot: I haz the power
5 years, 5 months ago (2015-07-15 13:52:38 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198956

Powered by Google App Engine
This is Rietveld 408576698