Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issue 1239743002: Chromecast: adjust test generator GYP rules for ATV. (Closed)

Created:
5 years, 5 months ago by gunsch
Modified:
5 years, 5 months ago
Reviewers:
lcwu1, halliwell
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Chromecast: adjust test generator GYP rules for ATV. "cast_android_tests_internal" is currently a dep of the test generator target, which results in the build/test scripts trying to run it as an actual test target. R=halliwell@chromium.org,lcwu@chromium.org BUG=None Committed: https://crrev.com/2b0e12f7ea49ea1665bf663d0a86ca92c25d4d26 Cr-Commit-Position: refs/heads/master@{#338820}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M chromecast/chromecast_tests.gypi View 2 chunks +13 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
gunsch
5 years, 5 months ago (2015-07-15 05:08:47 UTC) #1
lcwu1
lgtm
5 years, 5 months ago (2015-07-15 05:14:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1239743002/1
5 years, 5 months ago (2015-07-15 05:16:25 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-15 05:20:44 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-15 05:22:14 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2b0e12f7ea49ea1665bf663d0a86ca92c25d4d26
Cr-Commit-Position: refs/heads/master@{#338820}

Powered by Google App Engine
This is Rietveld 408576698