base/base.isolate - Issue 1239653004: Update Clang build script and gyp file for 3.8.0 version bump

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/base.isolate

Issue 1239653004: Update Clang build script and gyp file for 3.8.0 version bump (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: try fixing base.isolate Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/base.isolate

diff --git a/base/base.isolate b/base/base.isolate

index c7ba651ac71f0924cb9c0f25a66bc58a2aa89d0a..2e34c7d1a641f1f1300dffe5b1c8577bb91f76af 100644

--- a/base/base.isolate

+++ b/base/base.isolate

@@ -36,7 +36,7 @@

['OS=="win" and asan==1 and component=="shared_library"', {

'variables': {

'files': [

- '../third_party/llvm-build/Release+Asserts/lib/clang/3.7.0/lib/windows/clang_rt.asan_dynamic-i386.dll',

+ '../third_party/llvm-build/Release+Asserts/lib/clang/<!(python <../tools/clang/scripts/update.py --print-clang-version)/lib/windows/clang_rt.asan_dynamic-i386.dll',

Nico 2015/07/15 19:17:50 isolate files aren't gyp files. I don't think <!()

hans 2015/07/15 19:56:09 :-( New idea: let's just grab the whole lib dir,

}],

« no previous file with comments | « no previous file | build/common.gypi » ('j') | no next file with comments »