extensions: tabs: set tab id to -1 for app/devtools windows

chrome/browser/extensions/api/tabs/tabs_event_router.cc

Index: chrome/browser/extensions/api/tabs/tabs_event_router.cc
diff --git a/chrome/browser/extensions/api/tabs/tabs_event_router.cc b/chrome/browser/extensions/api/tabs/tabs_event_router.cc
index c2bc47d3da0a3460b250b99021752a166a85fb5b..2796b125c31e22b861b083c43a2373931c3f313b 100644
--- a/chrome/browser/extensions/api/tabs/tabs_event_router.cc
+++ b/chrome/browser/extensions/api/tabs/tabs_event_router.cc
@@ -129,7 +129,7 @@ TabsEventRouter::TabsEventRouter(Profile* profile)
 
     // Also catch up our internal bookkeeping of tab entries.
     Browser* browser = *it;
-    if (browser->tab_strip_model()) {
+    if (browser->tab_strip_model() && !browser->is_devtools()) {

[not at google - send to devlin, 2015/07/17 16:44:58]

How about adding a util method to ExtensionTabUtil so that we don't need to
repeat this check so often? ExtensionTabUtil::BrowserSupportsTabs(browser) or
something.

[llandwerlin-old, 2015/07/17 17:05:04]

Done.

       for (int i = 0; i < browser->tab_strip_model()->count(); ++i) {
         WebContents* contents = browser->tab_strip_model()->GetWebContentsAt(i);
         int tab_id = ExtensionTabUtil::GetTabId(contents);
@@ -148,7 +148,7 @@ void TabsEventRouter::OnBrowserAdded(Browser* browser) {
 }
 
 void TabsEventRouter::RegisterForBrowserNotifications(Browser* browser) {
-  if (!profile_->IsSameProfile(browser->profile()))
+  if (!profile_->IsSameProfile(browser->profile()) || browser->is_devtools())

[not at google - send to devlin, 2015/07/17 16:44:58]

ExtensionTabUtil::BrowserSupportsTabs(browser)

[llandwerlin-old, 2015/07/17 17:05:04]

Done.

     return;
   // Start listening to TabStripModel events for this browser.
   TabStripModel* tab_strip = browser->tab_strip_model();