extensions: tabs: set tab id to -1 for app/devtools windows

chrome/common/extensions/api/tabs.json

Index: chrome/common/extensions/api/tabs.json
diff --git a/chrome/common/extensions/api/tabs.json b/chrome/common/extensions/api/tabs.json
index 1a41ba11ad9e02f838020301327ad394934d1aeb..9a7aefccda56f2bba8adfcfd4b2140f6ba01b6e8 100644
--- a/chrome/common/extensions/api/tabs.json
+++ b/chrome/common/extensions/api/tabs.json
@@ -11,7 +11,7 @@
         "id": "Tab",
         "type": "object",
         "properties": {
-          "id": {"type": "integer", "minimum": 0, "optional": true, "description": "The ID of the tab. Tab IDs are unique within a browser session. Under some circumstances a Tab may not be assigned an ID, for example when querying foreign tabs using the $(ref:sessions) API, in which case a session ID may be present."},
+          "id": {"type": "integer", "minimum": -1, "description": "The ID of the tab. Tab IDs are unique within a browser session. Under some circumstances a Tab may be -1, for example when querying foreign tabs using the $(ref:sessions) API, in which case a session ID may be present, or for applications and devtools windows."},

[not at google - send to devlin, 2015/07/16 17:09:23]

We can't change the optionality of fields.

As for changing the minimum to -1, this is fine, but I'd like to take this
opportunity to define a TAB_ID_NONE similar to a WINDOW_ID_NONE:

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/common/exte...

and use that where you've done your != -1 or > 0 checks, and mention it here.

[llandwerlin-old, 2015/07/17 11:32:04]

Thanks, I should have asked.

           // TODO(kalman): Investigate how this is ending up as -1 (based on window type? a bug?) and whether it should be optional instead.
           "index": {"type": "integer", "minimum": -1, "description": "The zero-based index of the tab within its window."},
           "windowId": {"type": "integer", "minimum": 0, "description": "The ID of the window the tab is contained within."},