chrome/browser/extensions/api/sessions/sessions_apitest.cc - Issue 1239643004: extensions: tabs: set tab id to -1 for app/devtools windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/sessions/sessions_apitest.cc

Issue 1239643004: extensions: tabs: set tab id to -1 for app/devtools windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: set tab id to -1 in session api Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/sessions/sessions_api.cc ('k') | chrome/browser/extensions/api/tabs/tabs_event_router.cc » ('j') | chrome/common/extensions/api/tabs.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/sessions/sessions_apitest.cc

diff --git a/chrome/browser/extensions/api/sessions/sessions_apitest.cc b/chrome/browser/extensions/api/sessions/sessions_apitest.cc

index 90ebba80a6259eb86377a3700d4270ba8aed71a8..ba487455b78530223e3356781fc1d9d124d5aa3e 100644

--- a/chrome/browser/extensions/api/sessions/sessions_apitest.cc

+++ b/chrome/browser/extensions/api/sessions/sessions_apitest.cc

@@ -253,7 +253,8 @@ testing::AssertionResult CheckSessionModels(const base::ListValue& devices,

for (size_t j = 0; j < tabs->GetSize(); ++j) {

const base::DictionaryValue* tab = NULL;

EXPECT_TRUE(tabs->GetDictionary(j, &tab));

- EXPECT_FALSE(tab->HasKey("id")); // sessions API does not give tab IDs

+ EXPECT_EQ(api_test_utils::GetInteger(tab, "id"),

+ -1); // sessions API does not give tab IDs

EXPECT_EQ(static_cast<int>(j), api_test_utils::GetInteger(tab, "index"));

EXPECT_EQ(0, api_test_utils::GetInteger(tab, "windowId"));

// Test setup code always sets tab 0 to selected (which means active in