Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: chrome/browser/extensions/api/desktop_capture/desktop_capture_api.cc

Issue 1239643004: extensions: tabs: set tab id to -1 for app/devtools windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: set tab id to -1 in session api Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/desktop_capture/desktop_capture_api.cc
diff --git a/chrome/browser/extensions/api/desktop_capture/desktop_capture_api.cc b/chrome/browser/extensions/api/desktop_capture/desktop_capture_api.cc
index 6fa89dda112ea77462bdb97af4796e09604e4025..622f2616f9d567f5c63184de2b1a0a886447918c 100644
--- a/chrome/browser/extensions/api/desktop_capture/desktop_capture_api.cc
+++ b/chrome/browser/extensions/api/desktop_capture/desktop_capture_api.cc
@@ -74,12 +74,12 @@ bool DesktopCaptureChooseDesktopMediaFunction::RunAsync() {
target_name = base::UTF8ToUTF16(content::IsOriginSecure(origin) ?
net::GetHostAndOptionalPort(origin) : origin.spec());
- if (!params->target_tab->id) {
+ if (params->target_tab->id < 0) {
error_ = kNoTabIdError;
return false;
}
- if (!ExtensionTabUtil::GetTabById(*(params->target_tab->id), GetProfile(),
+ if (!ExtensionTabUtil::GetTabById(params->target_tab->id, GetProfile(),
true, NULL, NULL, &web_contents, NULL)) {
error_ = kInvalidTabIdError;
return false;
« no previous file with comments | « no previous file | chrome/browser/extensions/api/sessions/sessions_api.cc » ('j') | chrome/common/extensions/api/tabs.json » ('J')

Powered by Google App Engine
This is Rietveld 408576698