extensions: tabs: set tab id to -1 for app/devtools windows

chrome/test/data/extensions/api_test/tabs/no_events/test.js

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+var errors = 0;
+

[not at google - send to devlin, 2015/07/20 21:29:18]

I would make this slightly more succinct with a single function like

function errorListener() { ++errors; }

and then use that like

chrome.tabs.onCreated.addListener(errorListener);
chrome.tabs.onRemoved.addListener(errorListener);
chrome.tabs.onUpdated.addListener(errorListener);

[llandwerlin-old, 2015/07/21 09:45:41]

Done.

+chrome.tabs.onCreated.addListener(function(id, info, tab) {
+  errors++;
+  chrome.test.assertTrue(false);

[not at google - send to devlin, 2015/07/20 21:29:18]

chrome.test.fail() would be more straightforward.

but that said, since you're failing the test in the chrome.test.sendMessage()
response if errors > 0, you don't need these calls to fail(). Better to
centralise.

[llandwerlin-old, 2015/07/21 09:45:41]

Done.

+});
+
+chrome.tabs.onRemoved.addListener(function(id, info) {
+  errors++;
+  chrome.test.assertTrue(false);
+});
+
+chrome.tabs.onUpdated.addListener(function(id, info) {
+  errors++;
+  chrome.test.assertTrue(false);
+});
+
+chrome.test.sendMessage('ready', function (message) {
+  if (errors == 0)
+    chrome.test.notifyPass();
+  else
+    chrome.test.notifyFail('Unexpected chrome.tabs events');
+});