Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: chrome/common/extensions/api/tabs.json

Issue 1239643004: extensions: tabs: set tab id to -1 for app/devtools windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: set tab id to -1 in session api Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/extensions/extension_tab_util.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 [ 5 [
6 { 6 {
7 "namespace": "tabs", 7 "namespace": "tabs",
8 "description": "Use the <code>chrome.tabs</code> API to interact with the br owser's tab system. You can use this API to create, modify, and rearrange tabs i n the browser.", 8 "description": "Use the <code>chrome.tabs</code> API to interact with the br owser's tab system. You can use this API to create, modify, and rearrange tabs i n the browser.",
9 "types": [ 9 "types": [
10 { 10 {
11 "id": "Tab", 11 "id": "Tab",
12 "type": "object", 12 "type": "object",
13 "properties": { 13 "properties": {
14 "id": {"type": "integer", "minimum": 0, "optional": true, "description ": "The ID of the tab. Tab IDs are unique within a browser session. Under some c ircumstances a Tab may not be assigned an ID, for example when querying foreign tabs using the $(ref:sessions) API, in which case a session ID may be present."} , 14 "id": {"type": "integer", "minimum": -1, "description": "The ID of the tab. Tab IDs are unique within a browser session. Under some circumstances a Ta b may not be -1, for example when querying foreign tabs using the $(ref:sessions ) API, in which case a session ID may be present, or for applications and devtoo ls windows."},
dgozman 2015/07/16 12:05:50 "may not be -1" -> "may be -1"
llandwerlin-old 2015/07/16 12:09:23 Done, thanks.
15 // TODO(kalman): Investigate how this is ending up as -1 (based on win dow type? a bug?) and whether it should be optional instead. 15 // TODO(kalman): Investigate how this is ending up as -1 (based on win dow type? a bug?) and whether it should be optional instead.
16 "index": {"type": "integer", "minimum": -1, "description": "The zero-b ased index of the tab within its window."}, 16 "index": {"type": "integer", "minimum": -1, "description": "The zero-b ased index of the tab within its window."},
17 "windowId": {"type": "integer", "minimum": 0, "description": "The ID o f the window the tab is contained within."}, 17 "windowId": {"type": "integer", "minimum": 0, "description": "The ID o f the window the tab is contained within."},
18 "openerTabId": {"type": "integer", "minimum": 0, "optional": true, "de scription": "The ID of the tab that opened this tab, if any. This property is on ly present if the opener tab still exists."}, 18 "openerTabId": {"type": "integer", "minimum": 0, "optional": true, "de scription": "The ID of the tab that opened this tab, if any. This property is on ly present if the opener tab still exists."},
19 "selected": {"type": "boolean", "description": "Whether the tab is sel ected.", "deprecated": "Please use $(ref:tabs.Tab.highlighted)."}, 19 "selected": {"type": "boolean", "description": "Whether the tab is sel ected.", "deprecated": "Please use $(ref:tabs.Tab.highlighted)."},
20 "highlighted": {"type": "boolean", "description": "Whether the tab is highlighted."}, 20 "highlighted": {"type": "boolean", "description": "Whether the tab is highlighted."},
21 "active": {"type": "boolean", "description": "Whether the tab is activ e in its window. (Does not necessarily mean the window is focused.)"}, 21 "active": {"type": "boolean", "description": "Whether the tab is activ e in its window. (Does not necessarily mean the window is focused.)"},
22 "pinned": {"type": "boolean", "description": "Whether the tab is pinne d."}, 22 "pinned": {"type": "boolean", "description": "Whether the tab is pinne d."},
23 "audible": {"type": "boolean", "optional": true, "description": "Wheth er the tab has produced sound over the past couple of seconds (but it might not be heard if also muted). Equivalent to whether the speaker audio indicator is sh owing."}, 23 "audible": {"type": "boolean", "optional": true, "description": "Wheth er the tab has produced sound over the past couple of seconds (but it might not be heard if also muted). Equivalent to whether the speaker audio indicator is sh owing."},
24 "muted": {"type": "boolean", "optional": true, "description": "Whether the tab is prevented from playing sound (but hasn't necessarily recently produc ed sound). Equivalent to whether the muted audio indicator is showing."}, 24 "muted": {"type": "boolean", "optional": true, "description": "Whether the tab is prevented from playing sound (but hasn't necessarily recently produc ed sound). Equivalent to whether the muted audio indicator is showing."},
(...skipping 1117 matching lines...) Expand 10 before | Expand all | Expand 10 after
1142 "tabId": {"type": "integer", "minimum": 0}, 1142 "tabId": {"type": "integer", "minimum": 0},
1143 "oldZoomFactor": {"type": "number"}, 1143 "oldZoomFactor": {"type": "number"},
1144 "newZoomFactor": {"type": "number"}, 1144 "newZoomFactor": {"type": "number"},
1145 "zoomSettings": {"$ref": "ZoomSettings"} 1145 "zoomSettings": {"$ref": "ZoomSettings"}
1146 } 1146 }
1147 }] 1147 }]
1148 } 1148 }
1149 ] 1149 ]
1150 } 1150 }
1151 ] 1151 ]
OLDNEW
« no previous file with comments | « chrome/browser/extensions/extension_tab_util.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698