chrome/common/omaha_query_params.h - Issue 12396002: Add chrome version information to extension update checks

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/omaha_query_params.h

Issue 12396002: Add chrome version information to extension update checks (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_COMMON_OMAHA_QUERY_PARAMS_H_

	6 #define CHROME_COMMON_OMAHA_QUERY_PARAMS_H_

	7

	8 #include <string>

	9

	10 #include "base/basictypes.h"

	11

	12 namespace chrome {

	13

	14 std::string GetOmahaQueryParams(const std::string& prod);
	asargent_no_longer_on_chrome 2013/03/06 00:45:06 nit: this method could use a brief overview commen nit: this method could use a brief overview comment explaining what it's for, and what the meaning of the \|prod\| parameter is. Also, would it make sense to have \|prod\| just be an enum like { CHROME, CHROMECRX, CHROMIUMCRX } which we'd map to a string in the implementation of this method? Do we expect to add other possible values anytime soon? jackhou 2013/03/06 03:56:36 Done. Not sure if we expect to add other values, Done. Not sure if we expect to add other values, but I think it's clearer as an enum in either case.
	15

	16 } // namespace chrome

	17

	18 #endif // CHROME_COMMON_OMAHA_QUERY_PARAMS_H_

OLD	NEW