Implement a new flow event API that allows binding flow events and regular events.

content/child/blink_platform_impl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/child/blink_platform_impl.h"
 
 #include <math.h>
 
 #include <vector>
 
@@ skipping 617 matching lines @@
     double timestamp,
     int num_args,
     const char** arg_names,
     const unsigned char* arg_types,
     const unsigned long long* arg_values,
     unsigned char flags) {
   base::TraceTicks timestamp_tt =
       base::TraceTicks() + base::TimeDelta::FromSecondsD(timestamp);
   base::trace_event::TraceEventHandle handle =
       TRACE_EVENT_API_ADD_TRACE_EVENT_WITH_THREAD_ID_AND_TIMESTAMP(
-          phase, category_group_enabled, name, id, trace_event_internal::kNoId,
-          base::PlatformThread::CurrentId(), timestamp_tt, num_args, arg_names,
-          arg_types, arg_values, NULL, flags);
+          phase,
+          category_group_enabled,
+          name,
+          id,
+          trace_event_internal::kNoId,  // context_id
+          base::PlatformThread::CurrentId(),

[beaudoin, 2015/07/29 18:55:43]

Should you have one for CurrentId()? It is it's unclead what it's for from the
variable name.

+          timestamp_tt,
+          num_args,
+          arg_names,
+          arg_types,
+          arg_values,
+          NULL,
+          flags);
   blink::Platform::TraceEventHandle result;
   memcpy(&result, &handle, sizeof(result));
   return result;
 }
 
 blink::Platform::TraceEventHandle BlinkPlatformImpl::addTraceEvent(
     char phase,
     const unsigned char* category_group_enabled,
     const char* name,
     unsigned long long id,
@@ skipping 13 matching lines @@
       if (arg_types[i] == TRACE_VALUE_TYPE_CONVERTABLE) {
         convertable_wrappers[i] =
             new ConvertableToTraceFormatWrapper(convertable_values[i]);
       }
     }
   }
   base::TraceTicks timestamp_tt =
       base::TraceTicks() + base::TimeDelta::FromSecondsD(timestamp);
   base::trace_event::TraceEventHandle handle =
       TRACE_EVENT_API_ADD_TRACE_EVENT_WITH_THREAD_ID_AND_TIMESTAMP(
-          phase, category_group_enabled, name, id, trace_event_internal::kNoId,
-          base::PlatformThread::CurrentId(), timestamp_tt, num_args, arg_names,
-          arg_types, arg_values, convertable_wrappers, flags);
+          phase,
+          category_group_enabled,
+          name,
+          id,
+          trace_event_internal::kNoId,  // context_id
+          base::PlatformThread::CurrentId(),

[beaudoin, 2015/07/29 18:55:43]

Ditto.

+          timestamp_tt,
+          num_args,
+          arg_names,
+          arg_types,
+          arg_values,
+          convertable_wrappers,
+          flags);
   blink::Platform::TraceEventHandle result;
   memcpy(&result, &handle, sizeof(result));
   return result;
 }
 
 void BlinkPlatformImpl::updateTraceEventDuration(
     const unsigned char* category_group_enabled,
     const char* name,
     TraceEventHandle handle) {
   base::trace_event::TraceEventHandle traceEventHandle;
@@ skipping 677 matching lines @@
   return WebString::fromUTF8(ui::KeycodeConverter::DomCodeToCodeString(
       static_cast<ui::DomCode>(dom_code)));
 }
 
 int BlinkPlatformImpl::domEnumFromCodeString(const WebString& code) {
   return static_cast<int>(ui::KeycodeConverter::CodeStringToDomCode(
       code.utf8().data()));
 }
 
 }  // namespace content