Implement a new flow event API that allows binding flow events and regular events.

ppapi/shared_impl/ppb_trace_event_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ppapi/shared_impl/ppb_trace_event_impl.h"
 
 #include "base/basictypes.h"
 #include "base/threading/platform_thread.h"
 #include "base/trace_event/trace_event.h"
 #include "ppapi/thunk/thunk.h"
@@ skipping 60 matching lines @@
     const char* arg_names[],
     const uint8_t arg_types[],
     const uint64_t arg_values[],
     uint8_t flags) {
   base::trace_event::TraceLog::GetInstance()
       ->AddTraceEventWithThreadIdAndTimestamp(
           phase,
           static_cast<const unsigned char*>(category_enabled),
           name,
           id,
-          trace_event_internal::kNoId,
           thread_id,

[dsinclair, 2015/07/21 18:11:49]

This file shouldn't need to change yet right? We added the overloads for this
reason.

[yuhaoz, 2015/07/21 18:22:34]

Right that's why I removed the kNoId. fmeawad@ for context_id. I removed it so
that it uses the overloaded version.
 

[dsinclair, 2015/07/21 18:32:50]

Just add the context_id into the overloaded version. We do want to move off the
old API onto the new one, I just think they should be separate CLs. So, this CL
shouldn't change Angle or PPAPI and we update each of them later then remove the
old API.

           base::TraceTicks::FromInternalValue(timestamp),
           num_args,
           arg_names,
           arg_types,
-      // This cast is necessary for LP64 systems, where uint64_t is defined as
-      // an unsigned long int, but trace_event internals are hermetic and
-      // accepts an |unsigned long long*|.  The pointer types are compatible but
-      // the compiler throws an error without an explicit cast.
-      reinterpret_cast<const unsigned long long*>(arg_values),
-      NULL,
-      flags);
+          // This cast is necessary for LP64 systems, where uint64_t is defined as

[vmpstr, 2015/07/21 18:03:41]

You'll probably need to rewrap the comment to be 80-col

+          // an unsigned long int, but trace_event internals are hermetic and
+          // accepts an |unsigned long long*|.  The pointer types are compatible but
+          // the compiler throws an error without an explicit cast.
+          reinterpret_cast<const unsigned long long*>(arg_values),
+          NULL,
+          flags);
 }
 
 // static
 int64_t TraceEventImpl::Now() {
   return base::TraceTicks::Now().ToInternalValue();
 }
 
 // static
 void TraceEventImpl::SetThreadName(const char* thread_name) {
   base::PlatformThread::SetName(thread_name);
@@ skipping 22 matching lines @@
 const PPB_Trace_Event_Dev_0_1* GetPPB_Trace_Event_Dev_0_1_Thunk() {
   return &g_ppb_trace_event_thunk_0_1;
 }
 
 const PPB_Trace_Event_Dev_0_2* GetPPB_Trace_Event_Dev_0_2_Thunk() {
   return &g_ppb_trace_event_thunk_0_2;
 }
 
 }  // namespace thunk
 }  // namespace ppapi