Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Unified Diff: components/cronet/android/test/mock_url_request_job_factory.cc

Issue 1239543003: [Cronet] Surface SSL cert error through CronetURLRequestAdapter::OnSSLCertificateError (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address Matt's comments Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/test/mock_url_request_job_factory.cc
diff --git a/components/cronet/android/test/mock_url_request_job_factory.cc b/components/cronet/android/test/mock_url_request_job_factory.cc
index 4a3030fb7a9669741d5f4915a40836b020442a6f..0f6eb54a880dbd4cd17fb2833f6ebefa5ad0170a 100644
--- a/components/cronet/android/test/mock_url_request_job_factory.cc
+++ b/components/cronet/android/test/mock_url_request_job_factory.cc
@@ -7,6 +7,7 @@
#include "base/android/jni_android.h"
#include "base/android/jni_string.h"
#include "jni/MockUrlRequestJobFactory_jni.h"
+#include "net/test/url_request/ssl_certificate_error_job.h"
#include "net/test/url_request/url_request_failed_job.h"
#include "net/test/url_request/url_request_mock_data_job.h"
@@ -15,6 +16,7 @@ namespace cronet {
void AddUrlInterceptors(JNIEnv* env, jclass jcaller) {
net::URLRequestMockDataJob::AddUrlHandler();
net::URLRequestFailedJob::AddUrlHandler();
+ net::SSLCertificateErrorJob::AddUrlHandler();
}
jstring GetMockUrlWithFailure(JNIEnv* jenv,
@@ -37,6 +39,11 @@ jstring GetMockUrlForData(JNIEnv* jenv,
return base::android::ConvertUTF8ToJavaString(jenv, url.spec()).Release();
}
+jstring GetMockUrlForSSLCertificateError(JNIEnv* jenv, jclass jcaller) {
+ GURL url(net::SSLCertificateErrorJob::GetMockUrl());
mmenke 2015/07/20 15:05:35 While you're here, this file should include url/gu
xunjieli 2015/07/20 15:09:44 Done.
+ return base::android::ConvertUTF8ToJavaString(jenv, url.spec()).Release();
+}
+
bool RegisterMockUrlRequestJobFactory(JNIEnv* env) {
return RegisterNativesImpl(env);
}

Powered by Google App Engine
This is Rietveld 408576698