Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1335)

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java

Issue 1239543003: [Cronet] Surface SSL cert error through CronetURLRequestAdapter::OnSSLCertificateError (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added a test Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java
diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java
index 21321f7945874daaf378c58b1be33fe87a402637..a78537720a6788a39dace20ed03234ab746b33c8 100644
--- a/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java
+++ b/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java
@@ -512,6 +512,23 @@ public class CronetUrlRequestTest extends CronetTestBase {
}
/**
+ * Tests that an SSL cert error will be reported via {@link UrlRequest#onFailed}.
+ */
+ @SmallTest
+ @Feature({"Cronet"})
+ public void testMockSSLCertificateError() throws Exception {
+ TestUrlRequestListener listener = startAndWaitForComplete(
+ MockUrlRequestJobFactory.getMockUrlForSSLCertificateError());
+ assertNull(listener.mResponseInfo);
+ assertNotNull(listener.mError);
+ assertTrue(listener.mOnErrorCalled);
+ assertEquals(-201, listener.mError.netError());
+ assertEquals("Exception in CronetUrlRequest: net::ERR_CERT_DATE_INVALID",
+ listener.mError.getMessage());
+ assertEquals(listener.mResponseStep, ResponseStep.NOTHING);
+ }
+
+ /**
* Checks that the buffer is updated correctly, when starting at an offset.
*/
@SmallTest

Powered by Google App Engine
This is Rietveld 408576698