[Cronet] Surface SSL cert error through CronetURLRequestAdapter::OnSSLCertificateError

net/test/url_request/ssl_certificate_error_job.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef NET_TEST_URL_REQUEST_SSL_CERTIFICATE_ERROR_JOB_H_
+#define NET_TEST_URL_REQUEST_SSL_CERTIFICATE_ERROR_JOB_H_
+
+#include "base/macros.h"
+#include "base/memory/weak_ptr.h"
+#include "net/url_request/url_request_test_job.h"
+#include "url/gurl.h"
+
+namespace net {
+
+// SSLCertificateErrorJob simulates a ERR_CERT_DATE_INVALID error.
+class SSLCertificateErrorJob : public URLRequestTestJob {

[mmenke, 2015/07/17 21:09:18]

Suggest using URLRequestJob instead.  URLRequestTestJob is just kinda weird, and
I don't think you're using anything from it.

[xunjieli, 2015/07/20 14:56:20]

Done.

+ public:
+  SSLCertificateErrorJob(URLRequest* request,
+                         NetworkDelegate* network_delegate);

[mmenke, 2015/07/17 21:09:18]

Nit:  Should forward declare NetworkDelegate and URLRequest.

[xunjieli, 2015/07/20 14:56:20]

Done.

+
+  // URLRequestTestJob implementation:
+  void Start() override;
+
+  // Adds the testing URLs to the URLRequestFilter.
+  static void AddUrlHandler();
+
+  static GURL GetMockUrl();
+
+ private:
+  ~SSLCertificateErrorJob() override;
+  void NotifyError();

[mmenke, 2015/07/17 21:09:18]

nit:  Blank line after destructor declaration.

[xunjieli, 2015/07/20 14:56:20]

Done.

+
+  base::WeakPtrFactory<SSLCertificateErrorJob> weak_factory_;
+
+  DISALLOW_COPY_AND_ASSIGN(SSLCertificateErrorJob);
+};
+
+}  // namespace net
+
+#endif  // NET_TEST_URL_REQUEST_SSL_CERTIFICATE_ERROR_JOB_H_