[Cronet] Surface SSL cert error through CronetURLRequestAdapter::OnSSLCertificateError

components/cronet/android/test/ssl_certificate_error_job.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_CRONET_ANDROID_TEST_SSL_CERTIFICATE_ERROR_JOB_H_
+#define COMPONENTS_CRONET_ANDROID_TEST_SSL_CERTIFICATE_ERROR_JOB_H_
+
+#include "base/macros.h"
+#include "base/memory/weak_ptr.h"
+#include "net/url_request/url_request_test_job.h"
+#include "url/gurl.h"
+
+namespace cronet {
+
+// SSLCertificateErrorJob simulates a net::ERR_CERT_DATE_INVALID error.
+class SSLCertificateErrorJob : public net::URLRequestTestJob {

[mmenke, 2015/07/17 19:29:59]

Suggest putting this in net/test/url_request, to make it less likely we end up
with another similar class.

[xunjieli, 2015/07/17 20:15:21]

Done. My initial concern was the use case of this class is pretty narrow. But I
guess it doesn't hurt to move this class there.

[mmenke, 2015/07/17 21:09:18]

There are a bunch of browser tests that need to get cert errors of various
sorts, at least some of which don't need real failing servers.  Using this class
would be one way to get them off the spawned test server.  Emily's hooking up a
way to mock out the cert verifier, so maybe this won't end up not being needed. 
We'll see.

[xunjieli, 2015/07/20 14:56:20]

Acknowledged. I see! Makes sense. Good to know. Thanks!

+ public:
+  SSLCertificateErrorJob(net::URLRequest* request,
+                         net::NetworkDelegate* network_delegate);
+
+  // net::URLRequestTestJob implementation:
+  void Start() override;
+
+  // Adds the testing URLs to the URLRequestFilter.
+  static void AddUrlHandler();
+
+  static GURL GetMockUrl();
+
+ protected:
+  ~SSLCertificateErrorJob() override;

[mmenke, 2015/07/17 19:29:59]

Can make this private, since there are no subclasses.

[xunjieli, 2015/07/17 20:15:21]

Done.

+
+ private:
+  void NotifyError();
+
+  base::WeakPtrFactory<SSLCertificateErrorJob> weak_factory_;
+
+  DISALLOW_COPY_AND_ASSIGN(SSLCertificateErrorJob);
+};
+
+}  // namespace cronet
+
+#endif  // COMPONENTS_CRONET_ANDROID_TEST_SSL_CERTIFICATE_ERROR_JOB_H_