pkg/unittest/lib/src/string_matchers.dart - Issue 12395024: Don't throw if a non-string is passed to RegExpMatcher.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/unittest/lib/src/string_matchers.dart

Issue 12395024: Don't throw if a non-string is passed to RegExpMatcher. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/unittest/lib/src/string_matchers.dart

===================================================================

--- pkg/unittest/lib/src/string_matchers.dart (revision 19421)

+++ pkg/unittest/lib/src/string_matchers.dart (working copy)

@@ -178,8 +178,8 @@

}

- bool matches(String item, MatchState matchState) =>

- _regexp.hasMatch(item);

+ bool matches(item, MatchState matchState) =>

+ item is String ? _regexp.hasMatch(item) : false;

Description describe(Description description) =>

description.add("match '${_regexp.pattern}'");

« no previous file with comments | « no previous file | no next file » | no next file with comments »