chrome/common/extensions/api/networking_private/networking_private_crypto.cc - Issue 1239493005: Remove some legacy versions of StartsWith and EndsWith.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/networking_private/networking_private_crypto.cc

Issue 1239493005: Remove some legacy versions of StartsWith and EndsWith. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: merge Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/web_applications/web_app_mac.mm ('k') | chrome/common/extensions/chrome_extensions_client.cc » ('j') | chrome/installer/gcapi/gcapi.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/networking_private/networking_private_crypto.cc

diff --git a/chrome/common/extensions/api/networking_private/networking_private_crypto.cc b/chrome/common/extensions/api/networking_private/networking_private_crypto.cc

index 7a3c5f31c68bc4ab4af72a1948ae68759f06de0b..bf2320ed6994f5adfd49ea83f48cdda30df8b57a 100644

--- a/chrome/common/extensions/api/networking_private/networking_private_crypto.cc

+++ b/chrome/common/extensions/api/networking_private/networking_private_crypto.cc

@@ -65,7 +65,8 @@ bool VerifyCredentials(

std::string common_name = verification_context->GetCommonName();

std::string translated_mac;

base::RemoveChars(connected_mac, ":", &translated_mac);

- if (!base::EndsWith(common_name, translated_mac, false)) {

+ if (!base::EndsWith(common_name, translated_mac,

+ base::CompareCase::INSENSITIVE_ASCII)) {

LOG(ERROR) << kErrorPrefix << "MAC addresses don't match.";

return false;

}

« no previous file with comments | « chrome/browser/web_applications/web_app_mac.mm ('k') | chrome/common/extensions/chrome_extensions_client.cc » ('j') | chrome/installer/gcapi/gcapi.cc » ('J')