Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Unified Diff: Source/core/frame/History.idl

Issue 1239463005: Replace history.options with history.scrollRestoration attribute (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Move setScrollRestorationType to History Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/frame/History.cpp ('k') | Source/core/frame/StateOptions.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/frame/History.idl
diff --git a/Source/core/frame/History.idl b/Source/core/frame/History.idl
index 5462033850909d3376e317015f46f12a648cdc13..c8ac612b6d865d08e6f60396641edc57189b2267 100644
--- a/Source/core/frame/History.idl
+++ b/Source/core/frame/History.idl
@@ -25,6 +25,8 @@
// https://html.spec.whatwg.org/#the-history-interface
+enum ScrollRestoration {"auto", "manual"};
+
[
GarbageCollected,
] interface History {
@@ -40,11 +42,10 @@
[CallWith=ExecutionContext] void forward();
// TODO(philipj): The SerializedScriptValue types should be any.
// TODO(philipj): The title arguments should simply be 'DOMString title'.
- // Note: The options arguments are part of the Scroll Restoration API.
- [RaisesException] void pushState(SerializedScriptValue data, [TreatUndefinedAs=NullString] DOMString? title, optional DOMString? url = null, optional StateOptions options);
- [RaisesException] void replaceState(SerializedScriptValue data, [TreatUndefinedAs=NullString] DOMString? title, optional DOMString? url = null, optional StateOptions options);
+ [RaisesException] void pushState(SerializedScriptValue data, [TreatUndefinedAs=NullString] DOMString? title, optional DOMString? url = null);
+ [RaisesException] void replaceState(SerializedScriptValue data, [TreatUndefinedAs=NullString] DOMString? title, optional DOMString? url = null);
// Experimental Scroll Restoration API
// https://www.chromestatus.com/features/5657284784947200
- [RuntimeEnabled=ScrollRestoration] readonly attribute StateOptions options;
+ [RuntimeEnabled=ScrollRestoration] attribute ScrollRestoration scrollRestoration;
};
« no previous file with comments | « Source/core/frame/History.cpp ('k') | Source/core/frame/StateOptions.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698