LayoutTests/fast/loader/scroll-position-restoration-for-history-api.html - Issue 1239463005: Replace history.options with history.scrollRestoration attribute

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/loader/scroll-position-restoration-for-history-api.html

Issue 1239463005: Replace history.options with history.scrollRestoration attribute (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Move setScrollRestorationType to History Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/history/scroll-restoration/scroll-restoration-push-replace.html ('k') | LayoutTests/platform/linux/fast/css/target-fragment-match-expected.png » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/loader/scroll-position-restoration-for-history-api.html

diff --git a/LayoutTests/fast/loader/scroll-position-restoration-for-history-api.html b/LayoutTests/fast/loader/scroll-position-restoration-for-history-api.html

index 14c1555f7290f69a4bacde72aa2ea94ac073b71b..82405880c172ad01937d93992ebcda963ba7016d 100644

--- a/LayoutTests/fast/loader/scroll-position-restoration-for-history-api.html

+++ b/LayoutTests/fast/loader/scroll-position-restoration-for-history-api.html

@@ -35,8 +35,6 @@ function handleNavigation() {

for (var key in tests) {

var test = tests[key];

var args = [{key: key}, '', key];

- if ('options' in test)

- args.push(test.options);

if (test.type == 'push') {

history.pushState.apply(history, args);

@@ -45,6 +43,9 @@ function handleNavigation() {

history.replaceState.apply(history, args);

}

+ if ('options' in test)

+ history.scrollRestoration = test.options.scrollRestoration;

window.scrollBy(50, 100);

}