Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issue 1239423004: SIMD.js: Update Float32x4 and tests to current spec. (Closed)

Created:
5 years, 5 months ago by bbudge
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

SIMD.js: Update Float32x4 and tests to current spec. LOG=N BUG=v8:4124 Committed: https://crrev.com/5d8c1054280f514579b8a9468e6d0a4929745c8c Cr-Commit-Position: refs/heads/master@{#29781}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Rebase. #

Patch Set 3 : Fix TestHeapProfiler. #

Patch Set 4 : Fix mjsunit/messages.js #

Patch Set 5 : Skip tests that haven't been updated to new spec. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -40 lines) Patch
M src/harmony-simd.js View 2 chunks +18 lines, -4 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/simd.js View 5 chunks +30 lines, -29 lines 0 comments Download
M test/mjsunit/messages.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M test/simdjs/harness-adapt.js View 1 chunk +4 lines, -0 lines 0 comments Download
M test/simdjs/simdjs.status View 1 2 3 4 1 chunk +5 lines, -1 line 0 comments Download
M test/simdjs/testcfg.py View 1 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
bbudge
https://codereview.chromium.org/1239423004/diff/1/src/harmony-simd.js File src/harmony-simd.js (right): https://codereview.chromium.org/1239423004/diff/1/src/harmony-simd.js#newcode87 src/harmony-simd.js:87: DONT_ENUM | READ_ONLY); This was different from almost every ...
5 years, 5 months ago (2015-07-20 23:39:40 UTC) #2
bbudge
https://codereview.chromium.org/1239423004/diff/1/test/simdjs/testcfg.py File test/simdjs/testcfg.py (right): https://codereview.chromium.org/1239423004/diff/1/test/simdjs/testcfg.py#newcode67 test/simdjs/testcfg.py:67: On 2015/07/20 23:39:40, bbudge wrote: > Incorporating some changes ...
5 years, 5 months ago (2015-07-21 00:37:21 UTC) #3
rossberg
lgtm
5 years, 5 months ago (2015-07-21 10:21:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1239423004/100001
5 years, 5 months ago (2015-07-22 02:43:16 UTC) #8
commit-bot: I haz the power
Committed patchset #5 (id:100001)
5 years, 5 months ago (2015-07-22 03:14:00 UTC) #9
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/5d8c1054280f514579b8a9468e6d0a4929745c8c Cr-Commit-Position: refs/heads/master@{#29781}
5 years, 5 months ago (2015-07-22 03:14:20 UTC) #10
Michael Achenbach
Could you remove the now failing tests also from the benchmarks, e.g.: https://code.google.com/p/chromium/codesearch#chromium/src/v8/test/simdjs/SimdJs.json&l=168 Here is ...
5 years, 5 months ago (2015-07-23 08:29:33 UTC) #12
bbudge
On 2015/07/23 08:29:33, Michael Achenbach wrote: > Could you remove the now failing tests also ...
5 years, 5 months ago (2015-07-23 11:17:49 UTC) #13
Michael Achenbach
5 years, 5 months ago (2015-07-23 21:08:39 UTC) #14
Message was sent while issue was closed.
On 2015/07/23 11:17:49, bbudge wrote:
> On 2015/07/23 08:29:33, Michael Achenbach wrote:
> > Could you remove the now failing tests also from the benchmarks, e.g.:
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/v8/test/simdjs/Sim...
> > 
> > Here is an internal link to the failures:
> >
>
https://chromegw.corp.google.com/i/internal.client.v8/builders/v8_linux64_perf_2
> 
> The link to the failures is broken for me.

Try this:
https://uberchromegw.corp.google.com/i/internal.client.v8/builders/v8_linux64...

Powered by Google App Engine
This is Rietveld 408576698