Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 1239383004: Revert "Directly remove slot buffer entries in deoptimized code objects." (Closed)

Created:
5 years, 5 months ago by Hannes Payer (out of office)
Modified:
5 years, 5 months ago
Reviewers:
ulan
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert "Directly remove slot buffer entries in deoptimized code objects." This reverts commit 80b3f16951251d342ebaf9174872d50e46f048a5. Revert "Record code slots that may point to evacuation candidate objects after deoptimizing them." This reverts commit 4621210cfed738b8171b075f816f0c7329489c9d. BUG=chromium:507840 LOG=n Committed: https://crrev.com/4829bbc5d1a24a62337f1890f3d09ef36b602cec Cr-Commit-Position: refs/heads/master@{#29778}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -121 lines) Patch
M src/deoptimizer.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M src/heap/mark-compact.h View 8 chunks +19 lines, -16 lines 0 comments Download
M src/heap/mark-compact.cc View 10 chunks +164 lines, -54 lines 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +0 lines, -46 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
ulan
lgtm
5 years, 5 months ago (2015-07-21 15:21:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1239383004/20001
5 years, 5 months ago (2015-07-21 15:22:48 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-21 16:14:38 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 16:14:51 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4829bbc5d1a24a62337f1890f3d09ef36b602cec
Cr-Commit-Position: refs/heads/master@{#29778}

Powered by Google App Engine
This is Rietveld 408576698