Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 1239363003: Revert of cc: Call PrepareTiles when becoming visible in browser only. (Closed)

Created:
5 years, 5 months ago by Jeffrey Yasskin
Modified:
5 years, 5 months ago
Reviewers:
danakj, sunnyps, brianderson
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of cc: Call PrepareTiles when becoming visible in browser only. (patchset #4 id:60001 of https://codereview.chromium.org/1239843002/) Reason for revert: LayerTreeHostTestReadyToDrawVisibility times out under DrMemory: http://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28DrMemory%20full%29%20%285%29/builds/4546/steps/memory%20test%3A%20cc/logs/stdio [----------] 2 tests from LayerTreeHostTestReadyToDrawVisibility [ RUN ] LayerTreeHostTestReadyToDrawVisibility.RunSingleThread_DirectRenderer c:\b\build\slave\drm-cr\build\src\cc\test\layer_tree_test.cc(875): error: Failed Test timed out [ FAILED ] LayerTreeHostTestReadyToDrawVisibility.RunSingleThread_DirectRenderer (5044 ms) [ RUN ] LayerTreeHostTestReadyToDrawVisibility.RunSingleThread_DelegatingRenderer c:\b\build\slave\drm-cr\build\src\cc\test\layer_tree_test.cc(875): error: Failed Test timed out [ FAILED ] LayerTreeHostTestReadyToDrawVisibility.RunSingleThread_DelegatingRenderer (5244 ms) [----------] 2 tests from LayerTreeHostTestReadyToDrawVisibility (10292 ms total) Original issue's description: > cc: Call PrepareTiles when becoming visible in browser only. > > Calling PrepareTiles on each visibility change might have caused a v8 > idle time benchmark regression. We only need to call PrepareTiles for > the SingleThreadProxy wait for ready to draw mode. > > R=brianderson@chromium.org,danakj@chromium.org > TEST=LayerTreeHostTestReadyToDrawVisibility > BUG=499040 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/c67e9d831fa3753fc5434229d3275b1c0155edae > Cr-Commit-Position: refs/heads/master@{#339201} BUG=499040 Committed: https://crrev.com/e13101c1f51685c13c1a2f5bafa110027ef12d70 Cr-Commit-Position: refs/heads/master@{#339540}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -39 lines) Patch
M cc/trees/layer_tree_host_impl.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 1 chunk +0 lines, -29 lines 0 comments Download
M cc/trees/single_thread_proxy.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Jeffrey Yasskin
Created Revert of cc: Call PrepareTiles when becoming visible in browser only.
5 years, 5 months ago (2015-07-20 19:05:36 UTC) #1
Jeffrey Yasskin
5 years, 5 months ago (2015-07-20 19:07:50 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1239363003/1
5 years, 5 months ago (2015-07-20 19:08:00 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-20 20:34:45 UTC) #6
danakj
LGTM
5 years, 5 months ago (2015-07-20 22:28:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1239363003/1
5 years, 5 months ago (2015-07-20 22:28:58 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-20 22:35:38 UTC) #10
commit-bot: I haz the power
5 years, 5 months ago (2015-07-20 22:37:27 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e13101c1f51685c13c1a2f5bafa110027ef12d70
Cr-Commit-Position: refs/heads/master@{#339540}

Powered by Google App Engine
This is Rietveld 408576698