Issue 1239353002: Move rules for building Android Mojo services to //mojo/android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1239353002: Move rules for building Android Mojo services to //mojo/android (Closed)

Created:
5 years, 5 months ago by abarth-chromium

Modified:
5 years, 5 months ago

Reviewers:
etiennej

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Move rules for building Android Mojo services to //mojo/android This CL simplifies the downstream dependencies for building Mojo applications for Android because they no longer need to pull in //services/android to get this rules.gni file. R=etiennej@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/894a8dd5afe950d4ab0d5f38902e0c14c1ebd01b

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -167 lines)			Patch
M	examples/java_android/echo/BUILD.gn	View	1 chunk	+1 line, -1 line	0 comments	Download
M	examples/java_android/example_service/BUILD.gn	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	mojo/android/add_manifest_entry.py	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	mojo/android/rules.gni	View	2 chunks	+2 lines, -2 lines	0 comments	Download
D	services/android/add_manifest_entry.py	View	1 chunk	+0 lines, -54 lines	0 comments	Download
D	services/android/rules.gni	View	1 chunk	+0 lines, -103 lines	0 comments	Download
M	services/authentication/BUILD.gn	View	1 chunk	+1 line, -1 line	0 comments	Download
M	services/camera_roll/BUILD.gn	View	1 chunk	+1 line, -1 line	0 comments	Download
M	services/device_info/BUILD.gn	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	services/location/BUILD.gn	View	1 chunk	+1 line, -1 line	0 comments	Download
M	services/notifications/BUILD.gn	View	1 chunk	+1 line, -1 line	0 comments	Download
M	services/sensors/BUILD.gn	View	1 chunk	+1 line, -1 line	0 comments	Download
M	services/speech_recognizer/BUILD.gn	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

5 years, 5 months ago (2015-07-20 17:15:57 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
894a8dd5afe950d4ab0d5f38902e0c14c1ebd01b (presubmit successful).

Expand Messages | Collapse Messages