third_party/yasm/README.skia - Issue 1239333002: Reenable yasm for Android x86 and x86-64 on Linux

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/yasm/README.skia

Issue 1239333002: Reenable yasm for Android x86 and x86-64 on Linux (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Adding documentation Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « site/user/quick/android.md ('k') | third_party/yasm/config/android/yasm » ('j') | no next file with comments »

OLD	NEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 These platform specific Makefiles are necesary to build yasm on different platfo rms. The rest of	5 These platform specific Makefiles are necesary to build yasm on different platfo rms. The rest of

6 the yasm code is pulled into externals via the DEPS file.	6 the yasm code is pulled into externals via the DEPS file.

7	7

8 Chromium builds yasm using the below procedure. We take a few shortcuts. We mi rror Chromium's	8 Chromium builds yasm using the below procedure. We take a few shortcuts. We mi rror Chromium's

9 yasm repositories in our DEPS file, and we copy these config files directly from Chromium.	9 yasm repositories in our DEPS file, and we copy these config files directly from Chromium.

10	10

11 NOTE: We were are currently unable to build yasm for Android on x86 and x86_64. Instead we are

12 using a precompiled binary in the config/android directory.

13 TODO (msarett): Fix this!

14

15 Excerpt from [chromium] //src/third_party/yasm/README.chromium:	11 Excerpt from [chromium] //src/third_party/yasm/README.chromium:

16	12

17 Instructions for recreating the yasm.gyp file.	13 Instructions for recreating the yasm.gyp file.

18 1) Get a clean version of the yasm source tree. The clean tree can be found	14 1) Get a clean version of the yasm source tree. The clean tree can be found

19 at:	15 at:

20	16

21 src/third_party/yasm/source/yasm	17 src/third_party/yasm/source/yasm

22	18

23 2) Run configure on the pristine source from a different directory (eg.,	19 2) Run configure on the pristine source from a different directory (eg.,

24 /tmp/yasm_build). Running configure from another directory will keep	20 /tmp/yasm_build). Running configure from another directory will keep

(...skipping 104 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
129	125

130 Note that at least the gen_x86_insn.py script suffers from the same	126 Note that at least the gen_x86_insn.py script suffers from the same

131 problem as genmacro in that it outputs to the current directory by	127 problem as genmacro in that it outputs to the current directory by

132 default. The yasm.gyp build patches this file before invoking it to	128 default. The yasm.gyp build patches this file before invoking it to

133 allow specifying an output directory.	129 allow specifying an output directory.

134	130

135 10) Recreate the 'AdditionalOptions!': [ '/analyze' ] block so that VC++	131 10) Recreate the 'AdditionalOptions!': [ '/analyze' ] block so that VC++

136 /analyze builds won't fail.	132 /analyze builds won't fail.

137	133

138 11) If all that's is finished, attempt to build....and cross your fingers.	134 11) If all that's is finished, attempt to build....and cross your fingers.

OLD	NEW