Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2059)

Unified Diff: runtime/vm/thread_test.cc

Issue 1239323004: Remove unused field to fix clang build. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Remove argument from constructor. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/thread_test.cc
diff --git a/runtime/vm/thread_test.cc b/runtime/vm/thread_test.cc
index c6339bd550224dc5d9624442d8d67649151ba6a4..42b61b93ded76dbc92f7ad61b9a37ae6098423bb 100644
--- a/runtime/vm/thread_test.cc
+++ b/runtime/vm/thread_test.cc
@@ -109,11 +109,10 @@ class ObjectCounter : public ObjectPointerVisitor {
class TaskWithZoneAllocation : public ThreadPool::Task {
public:
TaskWithZoneAllocation(Isolate* isolate,
- const String& foo,
Monitor* monitor,
bool* done,
intptr_t id)
- : isolate_(isolate), foo_(foo), monitor_(monitor), done_(done), id_(id) {}
+ : isolate_(isolate), monitor_(monitor), done_(done), id_(id) {}
virtual void Run() {
Thread::EnterIsolateAsHelper(isolate_);
{
@@ -168,7 +167,6 @@ class TaskWithZoneAllocation : public ThreadPool::Task {
private:
Isolate* isolate_;
- const String& foo_;
Monitor* monitor_;
bool* done_;
intptr_t id_;
@@ -180,13 +178,12 @@ TEST_CASE(ManyTasksWithZones) {
Monitor sync[kTaskCount];
bool done[kTaskCount];
Isolate* isolate = Thread::Current()->isolate();
- String& foo = String::Handle(String::New("foo"));
EXPECT(isolate->heap()->GrowthControlState());
isolate->heap()->DisableGrowthControl();
for (int i = 0; i < kTaskCount; i++) {
done[i] = false;
Dart::thread_pool()->Run(
- new TaskWithZoneAllocation(isolate, foo, &sync[i], &done[i], i));
+ new TaskWithZoneAllocation(isolate, &sync[i], &done[i], i));
}
for (int i = 0; i < kTaskCount; i++) {
// Check that main mutator thread can still freely use its own zone.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698